-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi Arch Image Building for Devfile Index #414
Conversation
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
/retest |
Will re-run the tests later to see if it is just being flaky. Not sure what would have changed that would be affecting image builds since all of the default values are what it used to be. |
/retest |
1 similar comment
/retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jdubrick might be good to add a do-not-merge prefix in the title, until devfile/registry-support#245 is merged? wdyt?
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, maysunfaisal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?:
Summarize the changes. Are any stacks or samples added or updated?
These changes allow for the devfile index image to be built for multiple architectures and pushed to quay.io. The changes are:
build-multi-arch.sh
that takes care of building and pushing the index image to quay, built for bothlinux/amd64
andlinux/arm64
. It has the ability to build with either docker or podman.build.sh
to allow for an argument to be passed that allows the user to build for a different architecture.Dockerfile
andDockerfile.offline
to dynamically set the yq architecture.build.sh
script.Which issue(s) this PR fixes:
Link to github issue(s)
fixes devfile/api#1547
fixes devfile/api#1551
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer:
Since the Dockerfiles have
FROM quay.io/devfile/devfile-index-base:next
in them it is important that the PR opened for making the base image multi arch is merged prior to this. That PR can be found here.