Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Arch Image Building for Devfile Index #414

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

Jdubrick
Copy link
Contributor

@Jdubrick Jdubrick commented Jun 3, 2024

What does this PR do?:

Summarize the changes. Are any stacks or samples added or updated?
These changes allow for the devfile index image to be built for multiple architectures and pushed to quay.io. The changes are:

  • Addition of build-multi-arch.sh that takes care of building and pushing the index image to quay, built for both linux/amd64 and linux/arm64. It has the ability to build with either docker or podman.
  • Updated build.sh to allow for an argument to be passed that allows the user to build for a different architecture.
  • Updated Dockerfile and Dockerfile.offline to dynamically set the yq architecture.
  • Updated documentation for new build.sh script.
  • Updated github workflows to use the new scripts and build/push multi-arch to quay

Which issue(s) this PR fixes:

Link to github issue(s)
fixes devfile/api#1547
fixes devfile/api#1551

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

Since the Dockerfiles have FROM quay.io/devfile/devfile-index-base:next in them it is important that the PR opened for making the base image multi arch is merged prior to this. That PR can be found here.

@Jdubrick Jdubrick requested a review from a team as a code owner June 3, 2024 19:03
@openshift-ci openshift-ci bot requested a review from elsony June 3, 2024 19:03
@openshift-ci openshift-ci bot added the approved label Jun 3, 2024
@Jdubrick
Copy link
Contributor Author

Jdubrick commented Jun 3, 2024

/retest

@Jdubrick
Copy link
Contributor Author

Jdubrick commented Jun 3, 2024

@Jdubrick: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.14-images 0271133 link true /test v4.14-images
ci/prow/v4.14-registry-test 0271133 link true /test v4.14-registry-test
Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Will re-run the tests later to see if it is just being flaky. Not sure what would have changed that would be affecting image builds since all of the default values are what it used to be.

@Jdubrick
Copy link
Contributor Author

Jdubrick commented Jun 3, 2024

/retest

1 similar comment
@thepetk
Copy link
Contributor

thepetk commented Jun 4, 2024

/retest

@Jdubrick
Copy link
Contributor Author

Jdubrick commented Jun 4, 2024

/retest

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jdubrick might be good to add a do-not-merge prefix in the title, until devfile/registry-support#245 is merged? wdyt?

@Jdubrick
Copy link
Contributor Author

Jdubrick commented Jun 5, 2024

@Jdubrick might be good to add a do-not-merge prefix in the title, until devfile/registry-support#245 is merged? wdyt?

@Jdubrick might be good to add a do-not-merge prefix in the title, until devfile/registry-support#245 is merged? wdyt?

Done!

Copy link
Member

@maysunfaisal maysunfaisal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Jun 6, 2024
Copy link

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, maysunfaisal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick Jdubrick merged commit 0787b6d into devfile:main Jun 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
3 participants