Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Maven Java stack #412

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Update Maven Java stack #412

merged 1 commit into from
Jun 11, 2024

Conversation

azatsarynnyy
Copy link
Contributor

What does this PR do?:

Summarize the changes. Are any stacks or samples added or updated?

  • update schema to 2.2.2;
  • use https protocol for the java-maven devfile

Which issue(s) this PR fixes:

Link to github issue(s)
eclipse-che/che#22869

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

https://workspaces.openshift.com/#https://raw.githubusercontent.com/azatsarynnyy/registry/java-maven-update/stacks/java-maven/1.3.1/devfile.yaml

Signed-off-by: Artem Zatsarynnyi <[email protected]>
@azatsarynnyy azatsarynnyy requested review from kadel and a team as code owners May 27, 2024 13:53
@openshift-ci openshift-ci bot requested review from elsony and thepetk May 27, 2024 13:53
Copy link

openshift-ci bot commented May 27, 2024

Hi @azatsarynnyy. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@azatsarynnyy
Copy link
Contributor Author

also, I opened odo-devfiles/springboot-ex#5

@Jdubrick
Copy link
Contributor

/ok-to-test

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping from 1.3.0 to 1.3.1 to contain schema change + http -> https is identical to what was done here for example:
go 1.2.0 -> go 1.2.1

Since it was done before for consistency I'm okay with this change but I do wonder if using a patch version for increasing the schema version is the right move instead of creating a new 1.4.0 stack?

cc @michael-valdron @thepetk

Copy link
Collaborator

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
screenshot-nimbusweb me-2024 06 04-09_58_01

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Jun 4, 2024
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general lgtm now that we have bumped the devfile version.

@kadel as the owner of the stack could you please review the PR?

@ibuziuk
Copy link
Collaborator

ibuziuk commented Jun 11, 2024

@thepetk can we merge ?

@thepetk
Copy link
Contributor

thepetk commented Jun 11, 2024

@thepetk can we merge ?

@ibuziuk I've pinged the owner directly. Once is approved by the stack owner I'll merge it :)

Copy link

openshift-ci bot commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: azatsarynnyy, ibuziuk, kadel, svor
Once this PR has been reviewed and has the lgtm label, please assign thepetk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit eaba8b9 into devfile:main Jun 11, 2024
10 checks passed
@azatsarynnyy azatsarynnyy deleted the java-maven-update branch June 12, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Looks good to me ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants