-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Maven Java
stack
#412
Conversation
Signed-off-by: Artem Zatsarynnyi <[email protected]>
Hi @azatsarynnyy. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
also, I opened odo-devfiles/springboot-ex#5 |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumping from 1.3.0
to 1.3.1
to contain schema change + http -> https is identical to what was done here for example:
go 1.2.0 -> go 1.2.1
Since it was done before for consistency I'm okay with this change but I do wonder if using a patch version for increasing the schema version is the right move instead of creating a new 1.4.0
stack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in general lgtm now that we have bumped the devfile version.
@kadel as the owner of the stack could you please review the PR?
@thepetk can we merge ? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: azatsarynnyy, ibuziuk, kadel, svor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?:
Summarize the changes. Are any stacks or samples added or updated?
2.2.2
;https
protocol for thejava-maven
devfileWhich issue(s) this PR fixes:
Link to github issue(s)
eclipse-che/che#22869
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer:
https://workspaces.openshift.com/#https://raw.githubusercontent.com/azatsarynnyy/registry/java-maven-update/stacks/java-maven/1.3.1/devfile.yaml