Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update php-laravel devfile #349

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Update php-laravel devfile #349

merged 2 commits into from
Apr 4, 2024

Conversation

dkwon17
Copy link
Contributor

@dkwon17 dkwon17 commented Mar 28, 2024

What does this PR do?:

Summarize the changes. Are any stacks or samples added or updated?

  1. Created new version folder 2.0.1
  2. Updated schema version to 2.2.2
  3. Updated endpoint protocol to https
  4. Set the default version to 2.0.1 in stack.yaml

Which issue(s) this PR fixes:

Link to github issue(s)

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

Copy link

openshift-ci bot commented Mar 28, 2024

Hi @dkwon17. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dkwon17 dkwon17 marked this pull request as ready for review March 28, 2024 23:24
@dkwon17 dkwon17 requested a review from a team as a code owner March 28, 2024 23:24
@openshift-ci openshift-ci bot requested review from ibuziuk and kadel March 28, 2024 23:24
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a minor change

stacks/php-laravel/2.0.1/devfile.yaml Outdated Show resolved Hide resolved
@dkwon17
Copy link
Contributor Author

dkwon17 commented Apr 2, 2024

Thank you, I fixed the changes, but I had to force push to my branch to remove the unsigned commit

@thepetk thepetk self-requested a review April 3, 2024 09:03
@thepetk
Copy link
Contributor

thepetk commented Apr 3, 2024

Thank you, I fixed the changes, but I had to force push to my branch to remove the unsigned commit

Thanks! The only thing remains from our side is to address the failing check issue devfile/api#1494

/hold

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Apr 3, 2024
Copy link

openshift-ci bot commented Apr 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkwon17, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 3, 2024
@thepetk
Copy link
Contributor

thepetk commented Apr 3, 2024

/retest

@thepetk
Copy link
Contributor

thepetk commented Apr 3, 2024

@dkwon17 could you please rebase with the latest main. I think the issue with the odov3 check will be fixed

dkwon17 and others added 2 commits April 3, 2024 17:55
Co-authored-by: Theofanis Petkos <[email protected]>
Signed-off-by: dkwon17 <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Looks good to me label Apr 3, 2024
Copy link

openshift-ci bot commented Apr 3, 2024

New changes are detected. LGTM label has been removed.

@thepetk
Copy link
Contributor

thepetk commented Apr 4, 2024

Tested locally and it looks good.

@thepetk thepetk merged commit 61644f0 into devfile:main Apr 4, 2024
10 checks passed
thepetk added a commit to thepetk/registry that referenced this pull request Apr 22, 2024
* Update php-laravel devfile

Signed-off-by: dkwon17 <[email protected]>

* Update endpoint name

Co-authored-by: Theofanis Petkos <[email protected]>
Signed-off-by: dkwon17 <[email protected]>

---------

Signed-off-by: dkwon17 <[email protected]>
Co-authored-by: Theofanis Petkos <[email protected]>
Signed-off-by: thepetk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants