Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stacks/java-websphereliberty-gradle/devfile.yaml #344

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?:

  • update schema to 2.2.0;
  • use https protocol for the java-websphereliberty-gradle devfile.

Which issue(s) this PR fixes:

Link to github issue(s)

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

https://workspaces.openshift.com/#https://raw.githubusercontent.com/akurinnoy/registry/patch-2/stacks/java-websphereliberty-gradle/devfile.yaml

@openshift-ci openshift-ci bot requested review from ajm01 and yangcao77 March 25, 2024 13:51
Copy link

openshift-ci bot commented Mar 25, 2024

Hi @akurinnoy. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akurinnoy I think we should also bump up the version of the devfile

I'd suggest bumping up to 0.5.0

@thepetk
Copy link
Contributor

thepetk commented Apr 1, 2024

/ok-to-test

@akurinnoy
Copy link
Contributor Author

@thepetk thanks for the feedback, fixed.

@thepetk thepetk self-requested a review April 2, 2024 11:13
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajm01 as you are listed in the OWNERS file could you please review this PR?

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Apr 3, 2024
@thepetk thepetk self-requested a review April 3, 2024 14:17
@thepetk
Copy link
Contributor

thepetk commented Apr 3, 2024

/hold as we need first the approval of the stack owner

@openshift-ci openshift-ci bot added do-not-merge/hold and removed lgtm Looks good to me labels Apr 3, 2024
@thepetk
Copy link
Contributor

thepetk commented Apr 16, 2024

@ajm01 as you are listed in the OWNERS file could you please review this PR?

@ajm01 kind reminder to review the PR as you are listed as an owner. As discussed in the devfiles community call, we will wait for a week, until 23 Apr 2024, so the owner has time to review. In case we don't have a review from the owner, the devfile services team will review & merge the updates to unblock the eclipse che team.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Apr 23, 2024
Copy link

openshift-ci bot commented Apr 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 25d9cef into devfile:main Apr 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants