Update stacks/java-websphereliberty/devfile.yaml

[akurinnoy]

What does this PR do?:

• update schema to 2.2.0;
• use https protocol for the java-websphereliberty devfile.

Which issue(s) this PR fixes:

Link to github issue(s)

PR acceptance criteria:

• Contributing guide
  Have you read the devfile registry contributing guide and followed its instructions?
• Test automation
  Does this repository's tests pass with your changes?
• Documentation
  Does any documentation need to be updated with your changes?
• Check Tools Provider
  Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

https://workspaces.openshift.com/#https://raw.githubusercontent.com/akurinnoy/registry/patch-1/stacks/java-websphereliberty/devfile.yaml

[openshift-ci]

Hi @akurinnoy. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[thepetk]

I've added a minor suggestion regarding the name of the endpoint. @ajm01 as you re listed as an owner of this stack, could you please review the PR?

[thepetk]

/lgtm Tested locally with odo 3. I wasn't able to run the run command but the failure is not related to this update. As mentioned to my previous comment the PR needs to be approved from the stack owner first in order to be merged.

[thepetk]

/hold

[thepetk]

/ok-to-test

[akurinnoy]

/retest

[thepetk]

/lgtm Tested locally with odo 3. I wasn't able to run the run command but the failure is not related to this update. As mentioned to my previous comment the PR needs to be approved from the stack owner first in order to be merged.

@akurinnoy I've revisited my initial review. A minor suggestion is to bump up the version of the devfile too

registry/stacks/java-websphereliberty/devfile.yaml

Line 34 in 0ccd117

version: 0.9.0

I'd suggest bumping up to 0.10.0

[akurinnoy]

@thepetk thanks, fixed.

[thepetk]

@ajm01 as you are listed in the OWNERs file could you please review the PR?

[thepetk]

@thepetk thanks, fixed.

@akurinnoy I think there's a small error with the DCO

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, svor, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• stacks/OWNERS [thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[thepetk]

@ajm01 as you are listed in the OWNERs file could you please review the PR?

@ajm01 kind reminder to review the PR as you are listed as an owner. As discussed in the devfiles community call, we will wait for a week, until 23 Apr 2024, so the owner has time to review. In case we don't have a review from the owner, the devfile services team will review & merge the updates to unblock the eclipse che team.

[thepetk]

@ajm01 as you are listed in the OWNERs file could you please review the PR?

@ajm01 kind reminder to review the PR as you are listed as an owner. As discussed in the devfiles community call, we will wait for a week, until 23 Apr 2024, so the owner has time to review. In case we don't have a review from the owner, the devfile services team will review & merge the updates to unblock the eclipse che team.

Merged