Skip to content

Commit

Permalink
Replace nodejs icon link with devfile-stack-icons link (#226)
Browse files Browse the repository at this point in the history
* Add only default tags in index component (#9)

Signed-off-by: thepetk <[email protected]>

* Update test cases

Signed-off-by: thepetk <[email protected]>

* Fix test cases typo

Signed-off-by: thepetk <[email protected]>

* Fix tags in index_extra.json

Signed-off-by: thepetk <[email protected]>

* Finalize test cases fixes

Signed-off-by: thepetk <[email protected]>

* Replace nodejs icons

Signed-off-by: thepetk <[email protected]>

---------

Signed-off-by: thepetk <[email protected]>
  • Loading branch information
thepetk authored Mar 21, 2024
1 parent 9445a83 commit 34df2fe
Show file tree
Hide file tree
Showing 18 changed files with 35 additions and 35 deletions.
8 changes: 4 additions & 4 deletions index/generator/library/library_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ func TestValidateIndexComponent(t *testing.T) {
"Case 8: check for missing arch",
schema.Schema{
Name: "nodejs",
Icon: "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
Icon: "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
Git: &schema.Git{
Remotes: map[string]string{
"origin": "https://github.com/redhat-developer/devfile-sample",
Expand All @@ -200,7 +200,7 @@ func TestValidateIndexComponent(t *testing.T) {
"Case 9: check for missing provider",
schema.Schema{
Name: "nodejs",
Icon: "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
Icon: "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
Versions: []schema.Version{
{
Version: "1.0.0",
Expand All @@ -226,7 +226,7 @@ func TestValidateIndexComponent(t *testing.T) {
"Case 10: check for missing supportUrl",
schema.Schema{
Name: "nodejs",
Icon: "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
Icon: "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
Versions: []schema.Version{
{
Version: "1.0.0",
Expand Down Expand Up @@ -361,7 +361,7 @@ func TestValidateIndexComponent(t *testing.T) {
"Case 16: test happy path for for sample component with new struct",
schema.Schema{
Name: "nodejs",
Icon: "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
Icon: "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
Versions: []schema.Version{
{
Version: "1.0.0",
Expand Down
2 changes: 1 addition & 1 deletion index/generator/tests/registry/extraDevfileEntries.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ samples:
- name: nodejs-basic
displayName: Basic NodeJS
description: A simple Hello World application
icon: https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg
icon: https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg
tags: ["NodeJS", "Express"]
projectType: nodejs
language: nodejs
Expand Down
2 changes: 1 addition & 1 deletion index/generator/tests/registry/index_extra.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"NodeJS",
"Express"
],
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"projectType": "nodejs",
"language": "nodejs",
"versions": [
Expand Down
6 changes: 3 additions & 3 deletions index/generator/tests/registry/index_main.json
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@
},
{
"name": "nodejs",
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"displayName": "NodeJS Runtime",
"description": "Stack with NodeJS 12",
"type": "stack",
Expand All @@ -337,7 +337,7 @@
"schemaVersion": "2.2.0",
"default": true,
"description": "Stack with NodeJS 12",
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"tags": ["NodeJS", "Express", "ubi8"],
"links": {
"self": "devfile-catalog/nodejs:1.0.0"
Expand Down Expand Up @@ -424,7 +424,7 @@
"description": "A simple Hello World application",
"type": "sample",
"tags": ["NodeJS", "Express"],
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"projectType": "nodejs",
"language": "nodejs",
"versions": [
Expand Down
4 changes: 2 additions & 2 deletions index/generator/tests/registry/index_registry.json
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@
{
"name": "nodejs",
"displayName": "NodeJS Runtime",
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"description": "Stack with NodeJS 12",
"type": "stack",
"tags": ["NodeJS", "Express", "ubi8"],
Expand All @@ -337,7 +337,7 @@
"schemaVersion": "2.2.0",
"default": true,
"description": "Stack with NodeJS 12",
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"tags": ["NodeJS", "Express", "ubi8"],
"links": {
"self": "devfile-catalog/nodejs:1.0.0"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
schemaVersion: 2.0.0
metadata:
name: nodejs
icon: https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg
icon: https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg
version: 1.0.1
displayName: Node.js Runtime
description: Stack with Node.js 14
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
schemaVersion: 2.2.0
metadata:
name: nodejs
icon: https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg
icon: https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg
version: 1.0.1
displayName: Node.js Runtime
description: Stack with Node.js 14
Expand Down
2 changes: 1 addition & 1 deletion index/generator/tests/registry/stacks/nodejs/devfile.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
schemaVersion: 2.2.0
metadata:
name: nodejs
icon: https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg
icon: https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg
version: 1.0.0
displayName: NodeJS Runtime
description: Stack with NodeJS 12
Expand Down
4 changes: 2 additions & 2 deletions index/server/pkg/util/index.json
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@
"version": "1.0.0",
"displayName": "NodeJS Runtime",
"description": "Stack with NodeJS 12",
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"type": "stack",
"tags": [
"NodeJS",
Expand Down Expand Up @@ -297,7 +297,7 @@
"version": "1.0.1",
"displayName": "Basic NodeJS",
"description": "A simple Hello World application",
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"type": "sample",
"projectType": "nodejs",
"language": "nodejs"
Expand Down
8 changes: 4 additions & 4 deletions index/server/registry-REST-API.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -1198,7 +1198,7 @@ curl http://devfile-registry.192.168.1.1.nip.io/v2index/sample
"NodeJS",
"Express"
],
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"projectType": "nodejs",
"language": "nodejs",
"versions": [
Expand Down Expand Up @@ -1565,7 +1565,7 @@ curl http://devfile-registry.192.168.1.1.nip.io/v2index/all
"NodeJS",
"Express"
],
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"projectType": "nodejs",
"language": "nodejs",
"versions": [
Expand Down Expand Up @@ -1776,7 +1776,7 @@ curl http://devfile-registry.192.168.1.1.nip.io/v2index/sample?minSchemaVersion=
"NodeJS",
"Express"
],
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"projectType": "nodejs",
"language": "nodejs",
"versions": [
Expand Down Expand Up @@ -1953,7 +1953,7 @@ metadata:
version: 1.0.1
displayName: Node.js Runtime
description: Stack with Node.js 14
icon: https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg
icon: https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg
tags: ['NodeJS', 'Express', 'ubi8']
projectType: 'nodejs'
language: 'javascript'
Expand Down
2 changes: 1 addition & 1 deletion index/server/tests/registry/extraDevfileEntries.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ samples:
- name: nodejs-basic
displayName: Basic NodeJS
description: A simple Hello World application
icon: https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg
icon: https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg
tags: ["NodeJS", "Express"]
projectType: nodejs
language: nodejs
Expand Down
2 changes: 1 addition & 1 deletion index/server/tests/registry/index_extra.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"NodeJS",
"Express"
],
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"projectType": "nodejs",
"language": "nodejs",
"versions": [
Expand Down
6 changes: 3 additions & 3 deletions index/server/tests/registry/index_main.json
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@
},
{
"name": "nodejs",
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"displayName": "NodeJS Runtime",
"description": "Stack with NodeJS 12",
"type": "stack",
Expand All @@ -354,7 +354,7 @@
"schemaVersion": "2.2.0",
"default": true,
"description": "Stack with NodeJS 12",
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"tags": [
"NodeJS",
"Express",
Expand Down Expand Up @@ -454,7 +454,7 @@
"NodeJS",
"Express"
],
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"projectType": "nodejs",
"language": "nodejs",
"versions": [
Expand Down
4 changes: 2 additions & 2 deletions index/server/tests/registry/index_registry.json
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@
},
{
"name": "nodejs",
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"displayName": "NodeJS Runtime",
"description": "Stack with NodeJS 12",
"type": "stack",
Expand All @@ -354,7 +354,7 @@
"schemaVersion": "2.2.0",
"default": true,
"description": "Stack with NodeJS 12",
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"tags": [
"NodeJS",
"Express",
Expand Down
8 changes: 4 additions & 4 deletions index/server/tests/resources/newIndexStruct.json
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@
"name": "nodejs",
"displayName": "NodeJS Runtime",
"description": "Stack with NodeJS 12",
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"type": "stack",
"tags": [
"NodeJS",
Expand All @@ -164,7 +164,7 @@
"schemaVersion": "2.0.0",
"default": true,
"description": "Stack with NodeJS 12",
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"tags": [
"NodeJS",
"Express",
Expand Down Expand Up @@ -195,7 +195,7 @@
"NodeJS",
"Express"
],
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"projectType": "nodejs",
"language": "nodejs",
"versions": [
Expand All @@ -209,7 +209,7 @@
}
},
"description": "nodejs with devfile v2.2.0",
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg"
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg"
}
]
},
Expand Down
4 changes: 2 additions & 2 deletions index/server/tests/resources/oldIndexStruct.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"version": "1.0.0",
"displayName": "NodeJS Runtime",
"description": "Stack with NodeJS 12",
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"type": "stack",
"tags": [
"NodeJS",
Expand Down Expand Up @@ -116,7 +116,7 @@
"NodeJS",
"Express"
],
"icon": "https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg",
"icon": "https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg",
"projectType": "nodejs",
"language": "nodejs",
"git": {
Expand Down
2 changes: 1 addition & 1 deletion tests/registry/extraDevfileEntries.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ samples:
- name: nodejs-basic
displayName: Basic Node.js
description: A simple Hello World Node.js application
icon: https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg
icon: https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg
tags: ["NodeJS", "Express"]
projectType: nodejs
language: nodejs
Expand Down
2 changes: 1 addition & 1 deletion tests/registry/stacks/nodejs/devfile.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
version: 1.0.0
displayName: NodeJS Runtime
description: Stack with NodeJS 12
icon: https://nodejs.org/static/images/logos/nodejs-new-pantone-black.svg
icon: https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/node-js.svg
tags: ["NodeJS", "Express", "ubi8"]
projectType: "nodejs"
language: "nodejs"
Expand Down

0 comments on commit 34df2fe

Please sign in to comment.