-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add scorecard workflow and badge #72
Conversation
Signed-off-by: Jordan Dubrick <[email protected]>
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 25.86% 25.86%
=======================================
Files 25 25
Lines 1415 1415
=======================================
Hits 366 366
Misses 1026 1026
Partials 23 23 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor comment :)
Signed-off-by: Jordan Dubrick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* add scorecard workflow and badge Signed-off-by: Jordan Dubrick <[email protected]> * remove irrelevant info Signed-off-by: Jordan Dubrick <[email protected]> --------- Signed-off-by: Jordan Dubrick <[email protected]>
* add scorecard workflow and badge Signed-off-by: Jordan Dubrick <[email protected]> * remove irrelevant info Signed-off-by: Jordan Dubrick <[email protected]> --------- Signed-off-by: Jordan Dubrick <[email protected]> Signed-off-by: thepetk <[email protected]>
Please specify the area for this PR
This is for the CNCF Cleaner badge as part of our effort to increase adherence to open source best practices.
What does does this PR do / why we need it:
This PR implements the GitHub workflow for code scanning for the OpenSSF scorecard. This tracks security vulnerabilities in the repository and gives the repo a score based off its findings. A similar issue to this was merged here: devfile/library#195
Which issue(s) this PR fixes:
fixes devfile/api#1386
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer: