Cncf cleaner tasks #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
- Coverage 25.86% 25.30% -0.57%
==========================================
Files 25 25
Lines 1415 1415
==========================================
- Hits 366 358 -8
- Misses 1026 1032 +6
- Partials 23 25 +2 ☔ View full report in Codecov by Sentry. |
michael-valdron
pushed a commit
to michael-valdron/devfile-registry-operator
that referenced
this pull request
Jan 24, 2024
* update readme to properly link to changelog Signed-off-by: Jordan Dubrick <[email protected]> * add exemptions and best practice badge Signed-off-by: Jordan Dubrick <[email protected]> * remove artifact hub exemption Signed-off-by: Jordan Dubrick <[email protected]> --------- Signed-off-by: Jordan Dubrick <[email protected]>
thepetk
pushed a commit
to thepetk/devfile-registry-operator
that referenced
this pull request
Aug 20, 2024
* update readme to properly link to changelog Signed-off-by: Jordan Dubrick <[email protected]> * add exemptions and best practice badge Signed-off-by: Jordan Dubrick <[email protected]> * remove artifact hub exemption Signed-off-by: Jordan Dubrick <[email protected]> --------- Signed-off-by: Jordan Dubrick <[email protected]> Signed-off-by: thepetk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please specify the area for this PR
What does does this PR do / why we need it:
This PR checks off most of the items required to achieve the cncf cleaner badge. It includes all items other than the best practices scorecard as that will be added later. This also corrects the changelog section in the readme and directs readers to our release notes changelog.
Which issue(s) this PR fixes:
fixes devfile/api#1386
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer: