-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mock func for DevfileData interface #93
Conversation
Should the mock_interface be under testingutil pkg, instead of our production pkg? |
@yangcao77 its usually kept in the same dir as the interface file. Thats the practice that I saw in online examples and odo as our close reference. I'll check more tho, brb |
Reasonable. If we have new interface for v3 in the future, we need to create matching mock funcs for new interface anyways. |
Signed-off-by: Maysun J Faisal <[email protected]>
Signed-off-by: Maysun J Faisal <[email protected]>
Signed-off-by: Maysun J Faisal <[email protected]>
Another thought on this PR: |
Signed-off-by: Maysun J Faisal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good to me
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Maysun J Faisal [email protected]
What does this PR do?
Adds mock funcs for the DevfileData interface via the mockgen tool
What issues does this PR fix or reference?
Fixes devfile/api#383
Is your PR tested? Consider putting some instruction how to test your changes
Yes, updated tests to use the mock data