Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema version to 2.2.2 for nodejs test child devfiles #213

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Update schema version to 2.2.2 for nodejs test child devfiles #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pkg/devfile/parser/parse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ import (
"sigs.k8s.io/yaml"
)

const schemaVersion = string(data.APISchemaVersion220)
const schemaVersion = string(data.APISchemaVersion222)

var isTrue bool = true
var isFalse bool = false
Expand Down Expand Up @@ -3275,7 +3275,7 @@ type setFields struct {
func Test_ParseDevfileParentFromData(t *testing.T) {

//mainDevfile is based on the nodejs basic sample which has a parent reference to the nodejs stack: https://registry.devfile.io/devfiles/nodejs
mainDevfile := `schemaVersion: 2.2.0
mainDevfile := `schemaVersion: 2.2.2
metadata:
name: nodejs
version: 2.1.1
Expand Down Expand Up @@ -4166,7 +4166,7 @@ func Test_parseFromURI(t *testing.T) {
},
}
rawContent := `
schemaVersion: 2.1.0
schemaVersion: 2.2.2
metadata:
name: devfile
version: 2.0.0
Expand Down Expand Up @@ -4317,7 +4317,7 @@ func Test_parseFromURI_GitProviders(t *testing.T) {
invalidRevision = "invalid-revision"
)

minimalDevfileContent := fmt.Sprintf("schemaVersion: 2.2.0\nmetadata:\n name: devfile")
minimalDevfileContent := fmt.Sprintf("schemaVersion: 2.2.2\nmetadata:\n name: devfile")
server := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
_, err := rw.Write([]byte(minimalDevfileContent))
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion tests/v2/devfiles/samples/Test_Parent_RegistryURL.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
schemaVersion: 2.1.0
schemaVersion: 2.2.2
parent:
id: nodejs
registryUrl: "https://registry.stage.devfile.io"
Expand Down
Loading