Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.19 #203

Merged
merged 8 commits into from
Mar 11, 2024
Merged

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Mar 7, 2024

What does this PR do?:

Updates devfile library to Go 1.19 with dependency updates.

Which issue(s) this PR fixes:

fixes devfile/api#1470

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

  • Unit/Functional tests

  • QE Integration test

  • Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

  • Client Impact

  • Gosec scans

How to test changes / Special notes to the reviewer:

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 61.01%. Comparing base (002b102) to head (1507864).

Files Patch % Lines
pkg/util/httpcache.go 0.00% 8 Missing ⚠️
pkg/util/util.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
+ Coverage   60.88%   61.01%   +0.12%     
==========================================
  Files          43       43              
  Lines        5103     5112       +9     
==========================================
+ Hits         3107     3119      +12     
+ Misses       1809     1804       -5     
- Partials      187      189       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Michael Valdron <[email protected]>
replaceSchemaFile.go Fixed Show fixed Hide fixed
.github/workflows/codecov.yml Fixed Show fixed Hide fixed
.github/workflows/go.yml Fixed Show fixed Hide fixed
.github/workflows/proxy-warming.yml Fixed Show fixed Hide fixed
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron michael-valdron changed the title WIP: Update to Go 1.19 Update to Go 1.19 Mar 8, 2024
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I think we should create a new release after the merge of this PR

Copy link

openshift-ci bot commented Mar 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron
Copy link
Member Author

/lgtm

I think we should create a new release after the merge of this PR

@thepetk Also after the dependabot PRs and devfile/api#1454.

@michael-valdron michael-valdron merged commit d6f74c0 into devfile:main Mar 11, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Devfile Library to use Go 1.19
2 participants