-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow bypass setting of default values #169
Conversation
Signed-off-by: Kim Tsao <[email protected]>
Signed-off-by: Kim Tsao <[email protected]>
Signed-off-by: Kim Tsao <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
+ Coverage 60.47% 61.28% +0.81%
==========================================
Files 37 37
Lines 4369 4373 +4
==========================================
+ Hits 2642 2680 +38
+ Misses 1567 1531 -36
- Partials 160 162 +2
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me. However, since setting setBooleanDefaults=false
will result in all unset boolean values in Nil state, better confirm this change will not cause any issue before merging
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kim-tsao, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We'll need to remove this commit and update the Devfile library once [1] is merged. [1] devfile/library#169
What does this PR do?:
Introduces a new parser option
SetBooleanDefaults
to allow clients the ability to bypass setting the defaults on the boolean properties.Which issue(s) this PR fixes:
devfile/api#1067
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
Gosec scans
How to test changes / Special notes to the reviewer: