Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from internal fs to afero fs #146

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

maysunfaisal
Copy link
Member

Signed-off-by: Maysun J Faisal [email protected]

What does this PR do?:

Updates the function's fs from internal to afero.

Why? Because

  • the internal fs belongs in the testing pkg github.com/devfile/library/pkg/testingutil/filesystem
  • it makes sense to have a generic fs rather than an internal one for tools to adopt

Which issue(s) this PR fixes:

N/A

PR acceptance criteria:

How to test changes / Special notes to the reviewer:

Tests should pass

@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao, maysunfaisal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kim-tsao,maysunfaisal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maysunfaisal maysunfaisal merged commit 053629a into devfile:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants