-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
632-devfile annotation support in generators #123
Conversation
Signed-off-by: Stephanie <[email protected]>
Signed-off-by: Stephanie <[email protected]>
Signed-off-by: Stephanie <[email protected]>
Signed-off-by: Stephanie <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should include some coverage for parent/plugin Annotation overrides in the parse_test.go
Signed-off-by: Stephanie <[email protected]>
@kim-tsao I've pushed a new commit to add annotation field in plugin & parent override tests. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kim-tsao, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@kadel Can you also help review if this PR addresses Odo's request. |
@yangcao77 Testing with odo, I can see that the
|
@feloy How did you get this content? you are using devfile writer? This should be a bug, and I will need to submit another PR in api to fix that. (devfile/api#682) Thanks for pointing out. annotations are not added to devfile v2.0.0 or v2.1.0, and we are not planning to do that. |
Signed-off-by: Stephanie <[email protected]>
New changes are detected. LGTM label has been removed. |
@feloy The annotation problem with writer should be fixed by the new commit in this PR, can you help test again? Thanks. |
@yangcao77 yes, the problem is fixed with this commit, thanks |
Signed-off-by: Stephanie <[email protected]>
What does this PR do?:
This PR is for devfile annotation support.
Which issue(s) this PR fixes:
Fixes devfile/api#632
Fixes devfile/api#675
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer: