Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not add to list if the element exist already #116

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

yangcao77
Copy link
Collaborator

@yangcao77 yangcao77 commented Sep 16, 2021

Signed-off-by: Stephanie [email protected]

What does this PR do?:

This PR updates the add functions to only append to list if the element does not exist in current list.
Also updates unit tests to check for expected result.

Which issue(s) this PR fixes:

Fixes devfile/api#622

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot requested review from elsony and kim-tsao September 16, 2021 17:45
@yangcao77 yangcao77 requested review from maysunfaisal and removed request for elsony September 16, 2021 17:46
Copy link
Contributor

@kim-tsao kim-tsao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only (optional) suggestion I have is to add additional command and component types for testing but since duplicate checks are only using the component name, it shouldn't make a difference.

@openshift-ci
Copy link

openshift-ci bot commented Sep 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangcao77 yangcao77 merged commit 61ec35a into devfile:main Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a component with the same name is added, an error is returned, but the component is still added
2 participants