Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parent tests #110

Merged
merged 1 commit into from
Aug 11, 2021
Merged

parent tests #110

merged 1 commit into from
Aug 11, 2021

Conversation

kim-tsao
Copy link
Contributor

@kim-tsao kim-tsao commented Aug 5, 2021

What does this PR do?:

  • Introduces tests and test artifacts to validate parent devfiles
  • Replaces the deprecated parseAndValidate method with ParseDevfileAndValidate

Which issue(s) this PR fixes:

devfile/api#510

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

N/A These are just functional tests

  • Documentation

N/A

  • Client Impact

N/A

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot requested review from elsony and yangcao77 August 5, 2021 20:38
@kim-tsao kim-tsao requested review from maysunfaisal and removed request for elsony August 5, 2021 20:38
@kim-tsao kim-tsao marked this pull request as ready for review August 5, 2021 21:22
go.mod Show resolved Hide resolved
tests/v2/libraryTest/library_test.go Show resolved Hide resolved
@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao, maysunfaisal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kim-tsao,maysunfaisal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kim-tsao kim-tsao merged commit a9bd336 into devfile:main Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants