Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding required field to networkingv1 ingress generator #105

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Adding required field to networkingv1 ingress generator #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/devfile/generator/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,7 @@ func getIngressSpec(ingressSpecParams IngressSpecParams) *extensionsv1.IngressSp
// getNetworkingV1IngressSpec gets a networking v1 ingress spec
func getNetworkingV1IngressSpec(ingressSpecParams IngressSpecParams) *networkingv1.IngressSpec {
path := "/"
pathTypeImplementationSpecific := networkingv1.PathTypeImplementationSpecific
if ingressSpecParams.Path != "" {
path = ingressSpecParams.Path
}
Expand All @@ -359,6 +360,8 @@ func getNetworkingV1IngressSpec(ingressSpecParams IngressSpecParams) *networking
},
},
},
//Field is required to be set based on attempt to create the ingress
PathType: &pathTypeImplementationSpecific,
},
},
},
Expand Down