Make certs generate themselves from container #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing in favour of following: https://docs.openshift.com/container-platform/4.1/authentication/certificates/service-serving-certificate.html |
JPinkney
pushed a commit
to JPinkney/che-workspace-operator
that referenced
this pull request
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes the certs generate themselves inside of the controller by using a job. It will run the job only if needed (there haven't been any previous completed jobs). If the job creates the certs then it will update the deployment with the correct volume/volumeMounts
What issues does this PR fix or reference?
eclipse-che/che#16251
Is it tested? How?
tested on crc and started theia workspace, currently diagnosing why cloud shell isn't starting properly