Make Workspace Controller generate TLS certs for webhook server #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error from server (InternalError): error when creating "./samples/cloud-shell.yaml": Internal error occurred: failed calling admission webhook "mutate-workspaces.che-workspace-controller.svc": Post https://workspace-controller.che-workspace-controller.svc:443/mutate-workspaces?timeout=30s: x509: certificate is valid for ..svc.cluster.local, not workspace-controller.che-workspace-controller.svc Signed-off-by: Sergii Leshchenko <[email protected]>
|
is not going to be finalized since it uses non-supported functionality from operator-sdk. See operator-framework/operator-sdk#419 (comment) |
JPinkney
pushed a commit
to JPinkney/che-workspace-operator
that referenced
this pull request
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes Workspace Controller generate TLS certs for webhook server
It's not working yet:
TODO read secret/configmap on start and write content into file to avoid pod restarting when cert is generated.
What issues does this PR fix or reference?
eclipse-che/che#16251
Is it tested? How?
It's not working yet