Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Annotations to DevWorkspaceRouting Endpoints CRD #1292

Closed
AObuchow opened this issue Jul 31, 2024 · 0 comments · Fixed by #1297
Closed

Add Annotations to DevWorkspaceRouting Endpoints CRD #1292

AObuchow opened this issue Jul 31, 2024 · 0 comments · Fixed by #1297
Assignees
Milestone

Comments

@AObuchow
Copy link
Collaborator

In order to resolve #1023 we need to modify the CRD for DevWorkspaceRouting's so that it's endpoints can have annotations that will be applied to the routes/ingresses associated with the endpoints defined in the DevWorkspace.

When creating the DevWorkspaceRouting spec, we can pass the annotations from the DevWorkspace endpoint to the DevWorkspaceRouting endpoint.

Since we're only adding a new field to the DWR CRD that is optional, this should not cause compatibility issues with older instances of the DWR.

@AObuchow AObuchow self-assigned this Jul 31, 2024
AObuchow added a commit to AObuchow/devworkspace-operator that referenced this issue Aug 6, 2024
@AObuchow AObuchow moved this to Ready for Review in Eclipse Che Team B Backlog Aug 7, 2024
AObuchow added a commit that referenced this issue Aug 13, 2024
@github-project-automation github-project-automation bot moved this from Ready for Review to ✅ Done in Eclipse Che Team B Backlog Aug 13, 2024
@dkwon17 dkwon17 added this to the v0.31.x milestone Sep 12, 2024
AObuchow added a commit to mancubus77/devworkspace-operator that referenced this issue Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants