Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add p7zip-plugins to base image for chectl #39

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

SDawley
Copy link
Contributor

@SDawley SDawley commented Oct 12, 2022

Fix to previous PR. I noticed the image build failed because shasum is a perl script and not actually equivalent to sha1sum.

Issue: che-incubator/chectl#2239
The chectl package-binaries command also packages for windows and needs 7zip to do so.
I also noticed that the sizes in the readme were slightly out of date so I updated the compressed size to match the size in quay and the uncompressed size to how big they were when running locally.

Steps to reproduce:

  • Create a Chectl workspace in the che dogfooding instance from https://github.com/SDawley/chectl/tree/contribute (my branch that contains the build fixes).
  • Build Chectl
  • Run the package-binaries command
    command fails:
    oclif-dev: building target chectl-win32-x64.tar.gz /bin/sh: 7z: command not found › Error: install 7-zip to package windows tarball error Command failed with exit code 2.

Steps to verify:

@SDawley SDawley requested a review from l0rd October 12, 2022 20:48
@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: l0rd, SDawley

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SDawley SDawley merged commit f5ffca8 into devfile:main Oct 18, 2022
@SDawley SDawley deleted the add7z branch October 18, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants