Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: actual install command is perl-Digest-SHA #37

Merged
merged 2 commits into from
Oct 10, 2022

Conversation

SDawley
Copy link
Contributor

@SDawley SDawley commented Oct 5, 2022

Fix to previous PR. I noticed the image build failed because shasum is a perl script and not actually equivalent to sha1sum.

Issue: che-incubator/chectl#2239
The chectl package-binaries command uses shasum, so we either have to add shasum to the image used to create a workspace or add a symlink from sha256sum (which we do have).

Steps to reproduce:

Steps to verify:

@l0rd
Copy link
Contributor

l0rd commented Oct 5, 2022

@SDawley can you please update the README file too?

Signed-off-by: Samantha Dawley <[email protected]>
@SDawley
Copy link
Contributor Author

SDawley commented Oct 5, 2022

@SDawley can you please update the README file too?

Added!
I didn't update the size since perl-Digest-SHA is 117kb installed.

@SDawley SDawley requested a review from l0rd October 7, 2022 18:21
@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: l0rd, SDawley

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SDawley SDawley merged commit 5ff9b15 into devfile:main Oct 10, 2022
@SDawley SDawley deleted the fixShasum branch October 10, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants