Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update endpoint tests #307

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Conversation

maysunfaisal
Copy link
Member

Signed-off-by: Maysun J Faisal [email protected]

What does this PR do?

Update the CI tests as they were not rebased before merging

What issues does this PR fix or reference?

Is your PR tested? Consider putting some instruction how to test your changes

yes

Docs PR

Signed-off-by: Maysun J Faisal <[email protected]>
@mmulholla
Copy link
Contributor

LGTM

Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the purpose of these tests is to detect incompatible changes, this should not have triggered a failure in the first place -- all devfiles with endpoint names <=15 chars are valid if the check is <=63 chars.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amisevsk, maysunfaisal
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maysunfaisal
Copy link
Member Author

maysunfaisal commented Jan 15, 2021

@amisevsk true but the tests were failing because the expected outcome was different. The tests were looking for err <=15 when master was <=63, this was because the test PR was not rebased with master before merging and got out of sync

So the trigger point was test PR had name > 15 and it would err out saying name should be <=15 but master schema already allowed <=63 for the name.

@maysunfaisal maysunfaisal merged commit 2c77856 into devfile:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants