Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update workflows to point to go.mod #84

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Update workflows to point to go.mod #84

merged 7 commits into from
Jun 17, 2024

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Jun 17, 2024

What does this PR do?

Replaces the hardcoded go version in the workflows by fetching the go version directly from the go.mod file.

Which issue(s) does this PR fix

N/A

PR acceptance criteria

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Unit/Functional tests

  • Documentation

How to test changes / Special notes to the reviewer

@openshift-ci openshift-ci bot requested review from elsony and Jdubrick June 17, 2024 14:29
@thepetk thepetk requested review from michael-valdron and removed request for elsony June 17, 2024 14:29
michael-valdron
michael-valdron requested changes Jun 17, 2024
View reviewed changes
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are causing the current check failures.

.github/workflows/CI.yml Outdated Show resolved Hide resolved
.github/workflows/check_registry.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/CI.yml Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jun 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.16%. Comparing base (8b953ba) to head (8314f1a).
Report is 7 commits behind head on main.

❗ Current head 8314f1a differs from pull request most recent head 1b82a5a

Please upload reports for the commit 1b82a5a to get more accurate results.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   73.16%   73.16%           
=======================================
  Files          11       11           
  Lines        1565     1565           
=======================================
  Hits         1145     1145           
  Misses        351      351           
  Partials       69       69

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

thepetk and others added 7 commits June 17, 2024 16:39
@thepetk
Update workflows
a26868b 
Signed-off-by: thepetk <[email protected]>
@thepetk
Bump up go version to 1.21 and k8s.io/apimachinery to v0.29.2 (devfil…
042134f 
…e#80)

* Bump up go to 1.21 and apimachinery to 0.29.2

Signed-off-by: thepetk <[email protected]>

* Update workflows and documentation

Signed-off-by: thepetk <[email protected]>

---------

Signed-off-by: thepetk <[email protected]>
@thepetk @michael-valdron
Update .github/workflows/CI.yml
0498128 
Co-authored-by: Michael Valdron <[email protected]>
Signed-off-by: thepetk <[email protected]>
@thepetk @michael-valdron
Update .github/workflows/check_registry.yaml
e10b965 
Co-authored-by: Michael Valdron <[email protected]>
Signed-off-by: thepetk <[email protected]>
@thepetk @michael-valdron
Update .github/workflows/release.yaml
1628f34 
Co-authored-by: Michael Valdron <[email protected]>
Signed-off-by: thepetk <[email protected]>
@thepetk @michael-valdron
Update .github/workflows/CI.yml
4645570 
Co-authored-by: Michael Valdron <[email protected]>
Signed-off-by: thepetk <[email protected]>
@thepetk
Revert formatting
1b82a5a 
Signed-off-by: thepetk <[email protected]>
Jdubrick
Jdubrick approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

As long as @michael-valdron likes the changes to his suggestions

@openshift-ci openshift-ci bot added the lgtm label Jun 17, 2024
michael-valdron
michael-valdron approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 42574ef into devfile:main Jun 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jdubrick Jdubrick Jdubrick approved these changes

@michael-valdron michael-valdron michael-valdron approved these changes

Assignees

@michael-valdron michael-valdron

@Jdubrick Jdubrick

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thepetk @michael-valdron @Jdubrick @openshift-merge-robot