Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create springboot sample 2.0.0 version #37

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

thepetk
Copy link

@thepetk thepetk commented Nov 7, 2023

What does this PR do?:

This PR creates a new version of java-springboot-basic sample. The new version uses the 2.1.0 version of python stack instead of the default one 1.2.0.

Which issue(s) this PR fixes:

fixes devfile/api#1360

@maysunfaisal
Copy link
Contributor

@thepetk didnt we discuss that parent might not be supported in ODC, 🤔

Signed-off-by: thepetk <[email protected]>
@thepetk thepetk requested a review from maysunfaisal November 21, 2023 22:26
@thepetk
Copy link
Author

thepetk commented Nov 21, 2023

@thepetk didnt we discuss that parent might not be supported in ODC, 🤔

@maysunfaisal as discussed together we will keep the parent overrides. I've also updated the port to 8080 instead of 8081

@thepetk thepetk merged commit beac7d1 into devfile-samples:v2.0.0 Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Devfile Samples to reference v2.2.0 Parent stacks
2 participants