Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Update port from 8081 to 8080 #33

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[DO NOT MERGE] Update port from 8081 to 8080 #33

wants to merge 7 commits into from

Conversation

maysunfaisal
Copy link
Contributor

  • Updates the devfile sample port from 8081 to 8080
  • Doesnt update the attribute alpha.dockerimage-port: 8081 because of backward compatibility in ODC earlier versions. We dont want to backport devfile/library update that far back.

maysunfaisal and others added 3 commits July 10, 2023 14:37
@maysunfaisal
Update port from 8081 to 8080
77f2a82 
Signed-off-by: Maysun J Faisal <[email protected]>
@maysunfaisal
Update dockerfile port
dd1ab74 
Signed-off-by: Maysun J Faisal <[email protected]>
@thepetk
Update devfile version
8fc311d 
Signed-off-by: thepetk <[email protected]>
@thepetk thepetk changed the base branch from main to v1.2.2 October 9, 2023 15:59
@thepetk thepetk marked this pull request as ready for review October 9, 2023 16:00
@thepetk
Copy link

thepetk commented Oct 9, 2023 •
edited
Loading

@maysunfaisal I've updated the base of the PR to point to the branch v2.0.0 in order the update of the port to be include to the new version of sample.

I've also added WIP as we need first to merge devfile/registry#219

@thepetk thepetk changed the title Update port from 8081 to 8080 WIP: Update port from 8081 to 8080 Oct 9, 2023
@thepetk
Copy link

thepetk commented Oct 16, 2023

fixes devfile/api#1112

@thepetk thepetk mentioned this pull request Oct 16, 2023
Closed
@thepetk
Fix dockerfile
eab2053 
Signed-off-by: thepetk <[email protected]>
@thepetk thepetk mentioned this pull request Oct 17, 2023
Merged
4 tasks
@thepetk thepetk changed the title WIP: Update port from 8081 to 8080 Update port from 8081 to 8080 Oct 18, 2023
@thepetk thepetk changed the base branch from v1.2.2 to v2.0.0 October 18, 2023 13:59
@thepetk thepetk changed the base branch from v2.0.0 to main October 23, 2023 12:21
@thepetk
Update README.md
8c83594 
Signed-off-by: thepetk <[email protected]>
@thepetk thepetk changed the title Update port from 8081 to 8080 [DO NOT MERGE] Update port from 8081 to 8080 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maysunfaisal @thepetk