Feat/921 change icons doc #954
Conversation
There was a problem hiding this comment.
We should elaborate a bit more how changing default icons actually can be done.
As I understand it, there are multiple ways like for example replacing a default icon but keeping the name or by defining a new default icon within the component.
Please also get 2 other approvals, as I can not verify if the process you described to update the icon is sufficient or not.
|
Hey @veilvokay , I am ready to approve the task, but we should merge the PR #952 from @davidken91 first. This may lead to some conflicts in your branch, as David also worked on the readme. This is why I will wait with the approval. |
README.md
Outdated
| ```sh | ||
| $ yarn compile:icons | ||
| ``` | ||
| 2. To check that your icon has been added run your porject locally and inspect the Icons tab: |
README.md
Outdated
| $ yarn start | ||
| ``` | ||
|
|
||
| 2. Navigate to the Checkbox tab in your loval Storybook |
README.md
Outdated
|
|
||
| > Note: If you use any of those components, make sure that you either haven't removed the icons they use from the project, or replaced missing icons with yours. | ||
|
|
||
| To remove any icon, sinmply navigate to `/icon-set` folder, delete icons you don't need in all resolutions and run: |
There was a problem hiding this comment.
Small typo. Looks good to me other than the small spelling mistakes
veilvokay
dismissed stale reviews from davidken91 and ChristianHoffmannS2
via
e4f9e65
|
Hey @veilvokay , #952 has just been merged and leads to some conflicts. Once these are resolved and we have 2 approvals again, we can also merge your branch :-) |
veilvokay
force-pushed
the
feat/921_change_icons_doc
branch
from
e4f9e65 to
52c1527
Compare
veilvokay
requested review from
davidken91,
thrbnhrtmnn and
ChristianHoffmannS2
* docs(general): add documentation how to change icon set * docs(general): fix a typo * docs(general): resolved PR comments * docs(general): added Change Icons section * docs(general): fixed hyperlinks layout * docs(general): fixed typos * docs(general): 921 removed leftovers after rebase
* docs(general): add documentation how to change icon set * docs(general): fix a typo * docs(general): resolved PR comments * docs(general): added Change Icons section * docs(general): fixed hyperlinks layout * docs(general): fixed typos * docs(general): 921 removed leftovers after rebase
No description provided.