Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-library): props alignment form label #949

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

RubirajAccenture
Copy link
Contributor

@RubirajAccenture RubirajAccenture commented Feb 22, 2024

closes #781

JpunktWpunkt
JpunktWpunkt previously approved these changes Feb 22, 2024
@JpunktWpunkt JpunktWpunkt self-requested a review February 22, 2024 11:06
Copy link
Contributor

@davidken91 davidken91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a unit test is failing for form label. I think you just need to double check the error class that's being applied

JpunktWpunkt
JpunktWpunkt previously approved these changes Feb 22, 2024
Copy link
Contributor

@thrbnhrtmnn thrbnhrtmnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RubirajAccenture ,

the updates look good for the Form Label in Storybook, but I saw that now other components that use the Form Label have a Form label in an error state per default. For example the Text Area is showing a Form Label in error state, even if the Text Are is not in an error state. Could you check that again?

Also I found two small other thing on the Form Label Storybook page:

  • All the section titles "Appearance", "Content / Settings" & "Validation" are having a bigger bottom-margin in the table of content than on other pages, resulting in big spaces in-between the table of content
  • The example story in the "Label Appendix" section is showing 3 Form Labels in the sizeVariant LG, but other examples are mostly showing the sizeVariant MD. Could you change the "Label Appendix" Story to use MD size for all 3 labels?

@RubirajAccenture RubirajAccenture force-pushed the fix-form-label-prop-alignment branch from 3f208d5 to b8fd833 Compare February 28, 2024 13:10
@RubirajAccenture RubirajAccenture force-pushed the fix-form-label-prop-alignment branch from b8fd833 to 454a9db Compare February 28, 2024 13:24
@thrbnhrtmnn thrbnhrtmnn merged commit 1495060 into develop Feb 28, 2024
3 of 4 checks passed
@thrbnhrtmnn thrbnhrtmnn deleted the fix-form-label-prop-alignment branch February 28, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form Label - Ensure Consistency between Storybook Documentation and Codebase Property Names
6 participants