Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui-components): implement events for number input #937

Merged
merged 9 commits into from
Mar 13, 2024

Conversation

remmycat
Copy link
Contributor

@remmycat remmycat commented Feb 20, 2024

Notes:

  • I tried writing tests for the other events too, but simulating the mouse and change events got rather complex - I couldn't get it working in the test environment. (I tried this: https://modern-web.dev/docs/test-runner/commands/#send-keys )
  • I added the type hints for the properties because I noticed the number conversions weren't happening without them, which broke my code. The other code just always converted everything that might be a string into a number / boolean. I removed those explicit conversions, since this would sweep invalid types under the rug otherwise. With the type hint lit will convert the values for us.

Ticket: #481

@ChristianHoffmannS2 ChristianHoffmannS2 force-pushed the feat/481_number-input-events branch 3 times, most recently from 3610ccc to 67ae8eb Compare February 28, 2024 13:00
@ChristianHoffmannS2 ChristianHoffmannS2 force-pushed the feat/481_number-input-events branch from 67ae8eb to c1558fe Compare February 28, 2024 13:04
@faselbaum faselbaum self-requested a review March 8, 2024 09:56
faselbaum
faselbaum previously approved these changes Mar 8, 2024
@faselbaum faselbaum requested review from JpunktWpunkt and removed request for JpunktWpunkt and ChristianHoffmannS2 March 8, 2024 11:05
@JpunktWpunkt JpunktWpunkt linked an issue Mar 11, 2024 that may be closed by this pull request
6 tasks
@JpunktWpunkt JpunktWpunkt added the 🦹 needs:reviewers (code) The issue or pull request needs additional code reviewers label Mar 11, 2024
@faselbaum faselbaum removed the 🦹 needs:reviewers (code) The issue or pull request needs additional code reviewers label Mar 11, 2024
@JpunktWpunkt JpunktWpunkt requested a review from faselbaum March 13, 2024 08:57
@JpunktWpunkt JpunktWpunkt added the 🦹 needs:reviewers (code) The issue or pull request needs additional code reviewers label Mar 13, 2024
@faselbaum faselbaum removed the 🦹 needs:reviewers (code) The issue or pull request needs additional code reviewers label Mar 13, 2024
@JpunktWpunkt JpunktWpunkt merged commit 9363f94 into develop Mar 13, 2024
4 of 5 checks passed
@JpunktWpunkt JpunktWpunkt deleted the feat/481_number-input-events branch March 13, 2024 09:20
ChristianHoffmannS2 added a commit that referenced this pull request Mar 26, 2024
* feat(ui-components): implement events for number input
---------

Co-authored-by: Christian Hoffmann <[email protected]>
Co-authored-by: JpunktWpunkt <[email protected]>
ChristianHoffmannS2 added a commit that referenced this pull request Mar 26, 2024
* feat(ui-components): implement events for number input
---------

Co-authored-by: Christian Hoffmann <[email protected]>
Co-authored-by: JpunktWpunkt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NumberInput - add missing events
5 participants