fix(documentation): create testing documentation (#371) #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angsherpa456
requested review from
ChristianHoffmannS2,
thrbnhrtmnn and
davidken91
angsherpa456
force-pushed
the
fix/371-testing-documentation
branch
from
8a5fa82 to
57db9c7
Compare
thrbnhrtmnn
reviewed
Feb 16, 2024
There was a problem hiding this comment.
Left a few comments. I think @ChristianHoffmannS2 should also do a review here :-)
angsherpa456
force-pushed
the
fix/371-testing-documentation
branch
from
57db9c7 to
70d980a
Compare
thrbnhrtmnn
requested changes
Feb 19, 2024
angsherpa456
force-pushed
the
fix/371-testing-documentation
branch
2 times, most recently
from
2189923 to
76a8fea
Compare
angsherpa456
force-pushed
the
fix/371-testing-documentation
branch
from
76a8fea to
55b6611
Compare
thrbnhrtmnn
approved these changes
Feb 20, 2024
davidken91
approved these changes
Feb 20, 2024
thrbnhrtmnn
added a commit
that referenced
this pull request
Feb 26, 2024
* feat(ui-library): add figma plugin to storybook (#703) * added lit-analyzer to compile step and updated vs code extensions (#714) * added lit-analyzer to compile step and updated vs code extensions * updated lit and added github worklflow * updated path * pathes stuff * github jobs renaming * ignore analyze in the pipeline * test the attribute * removed comment * dont update lit * dont update lit * fix lit-analyzer job (#721) * NumberInput - Fix the disappearing stepper buttons and hiding placeholder text (#719) * fix the numberinput to always display stepper before, stepper would disappear if you set the unit to undefined or readonly to true. this was because of conditonal rendering conditions. this fixes the problem by extracting the stepper render function outside the rendering condition of unit inside the input. * display the placeholder for default value the default value in not undefined, so it would hinder and unable the placeholder to be visible. this adds a condition to render the placeholder if it's not the default value * adds test for disappearing stepper buttons --------- Co-authored-by: Muhammad Usman <[email protected]> Co-authored-by: Christian Hoffmann <[email protected]> * fixing icon compile rimraf, fixing missing source icons and add lazy loading to icons and run test against build (#718) * commit before passing * got icons chunked * fix eslint issue * Delete doc/CONTRIBUTE.md (#727) - deleting old contribute file, so a new one that is linked in the About section of the repo can be added Signed-off-by: Thorben Hartmann <[email protected]> * Create CONTRIBUTING.md (#728) Adding a new contribute file, which will also be displayed under about on the repo starting page Signed-off-by: Thorben Hartmann <[email protected]> * Create CONTRIBUTING.md (#729) Signed-off-by: Thorben Hartmann <[email protected]> * Update README.md (#730) fixed links to: - contribution.md - code of conduct md - discussion board Signed-off-by: Thorben Hartmann <[email protected]> * docs: remove duplicate of contribution.md (#731) Removing the duplicate contribution.md file, as the correct file now is located outside of the doc folder. This change was done, to comply with the the GitHub Community Standards. Signed-off-by: Thorben Hartmann <[email protected]> * docs: update year in license (#732) - Updated year in license.md to 2023-2024 - Also fixed an error, where B01LER was not replacing the full placeholder Signed-off-by: Thorben Hartmann <[email protected]> * docs: update label section in contribute file (#738) Updated the labels under Tipps to find issues, and added the "core team issue" label, which was newly introduced. Signed-off-by: Thorben Hartmann <[email protected]> * docs: fix storybook link in README (#744) Signed-off-by: Thorben Hartmann <[email protected]> * fixed missing token and missing word wrap behaviour (#759) * feature/492-storybook-counter (#702) * feat(storybook): added Counter Stories --------- Co-authored-by: Christian Hoffmann <[email protected]> Co-authored-by: David Kennedy <[email protected]> * 545 form label rename tokens (#761) * fix(tokens): moves and renames label tokens are renamed to component name and moved into component sets * feat: adds FormLabel to style-dictionary.config * fix: apply renamed tokens to forms.css * feat(tokens) moving label colors to CMP forms.label.[state] stays in SEM but will not be applied onto component anymore * fix: replaces Forms.Label with Forms.FormLabel Also fixes LabelNextToControl colors in multiple files. * fix(tokens): move nextToConrol from SEM to CMP also renames to InlineLabel * fix: fix occurances of labelNextToControl This typotoken moved to CMP and was renamed to ..LabelInline.Typography. * moved checkbox css changes to component css file and deleted global * removed comma * readded correct tokens to checkbox * fixed radio css file --------- Co-authored-by: larserbach <[email protected]> * 540 textarea rename tokens (#762) * fix(tokens): renames textarea minHeight * fix: apply new tokennames at Textarea css --------- Co-authored-by: larserbach <[email protected]> * Removed configuration (#768) * feature/496-storybook-form-label (#686) * feat(storybook): added form Label Story * fix(storybook): added line break * fix(storybook): changed some little text and stories after review * fix(storybook): fixed some text changes after review --------- Co-authored-by: Thorben Hartmann <[email protected]> * fix/409-storybook-checkbox (#700) * fix(storybook): added some changes after review * fix(storybook): added changes after review --------- Co-authored-by: Thorben Hartmann <[email protected]> * Fix example app icons (#724) * we need a relative path here * fix for range slider only * fixed some imports and deactivated icon tests * now all tests run against build * prod fix of example app * added dependencies to story for buttons (#786) * added dependencies to story for buttons * fix for all * fixes icon keys (#788) * icon uses correct event handling for blrClick - fixes password (#787) * icon uses correct event handling for blrClick - fixes password * compile issues * feat: updates ItemSpacings to have different values per size (#769) * feat: updates ItemSpacings to have different values per size * remove configuration --------- Co-authored-by: larserbach <[email protected]> Co-authored-by: Christian Hoffmann <[email protected]> * docs: change readme picture (#795) Signed-off-by: Thorben Hartmann <[email protected]> * move config file out of src (#648) (#684) Co-authored-by: Christian Hoffmann <[email protected]> * 413-radio group docs (#690) * feat(storybook): initial commit * feat(storybook): add radio group docs * fix(ui): add feedback * fix(storybook): change folder name * fix(storybook): filenaming * fix(storybook): import issues * fix(storybook): import issue --------- Co-authored-by: Christian Hoffmann <[email protected]> * Feature/419 storybook toggle switch (#783) * feat(storybook): added argTableTypes * feature(storybook): added toggle-switch story * feature(storybook): added various stories * fix(storybook): added changes after review and add name property to component * fix(storybook): change story property order * fix(storybook): added changes after review * fix(storybook): another changes after review * fix(storybook): added changes after review * #550 tooltip rename tokens 2 (#794) * fixes tooltip tokens * apply new token names on tooltip-bubble/index.css * Adds tooltip elevation and typo tokens * fix tooltip tokens --------- Co-authored-by: David Kennedy <[email protected]> Co-authored-by: Christian Hoffmann <[email protected]> * #544 slider rename tokens (#796) * background color tokens * renames slider tokens * fix border tokens * apply tokens on slider.legend.css * update slider.css slider-legend.css range-slider-utils.ts --------- Co-authored-by: christian.b.hoffmann <[email protected]> * #544 form caption rename tokens (#801) * renames form caption tokens and moves them to CMP * Defines semantic caption tokens * adds CMP counter typo tokens * fix Referencing UI.Caption for typo now * Moves captionComponent css from form.css to captionComponent index.css Renames tokens * fix: tokens on counter component * fix: rename tokens in radio.css (We should check if caption tokens are really needed here) * minor adjustment --------- Co-authored-by: larserbach <[email protected]> * feat(storybook): add divider docs (#694) * feat(storybook): add divider docs * fix: adds comma in $themes (#804) * adds comma in $themes * fix: regenerate themes.json --------- Co-authored-by: larserbach <[email protected]> * Fix/712 fix scrolling (#791) * Implemented requestAnimationFrame to restore scroll position and focus * fix(ui-library): fixed contrast violation in disabled state (#802) * fix(ui-library): fixed contrast violation in disabled state for icon-button and text-button and fixed that the text can not be selected in disabled mode for different browsers --------- Co-authored-by: christian.b.hoffmann <[email protected]> Co-authored-by: Christian Hoffmann <[email protected]> * feat(storybook): add button group docs (#806) * feat(storybook): add button group docs * fix(storybook): add feedback * fix(storybook): delete labels and fix alignment --------- Co-authored-by: Christian Hoffmann <[email protected]> * feat(storybook): add icon docs (#756) * feat(ui): add icon docs * feat(storybook): add icon docs file * feat(storybook): add feedback * fix(storybook): fix prop order * fix(storybook): fix prop size * fix(storybook): fix props --------- Co-authored-by: Thorben Hartmann <[email protected]> * Code snipped fix (#814) * render functions doesnt use dots and handles boolean * solved! * arrays/objects should work again but wont show in code snipped * in case of boolean false, we have to give an excplicit false as property * Select: html options instead of array (#780) * feat(ui-library): replaced options array with slots in blrSelect component --------- Co-authored-by: David Kennedy <[email protected]> Co-authored-by: David Kennedy <[email protected]> * feat(ui-library): fixing caption component styles (#818) * Feature/513 tabbar use slots instead of arrays in the tabbar (#799) * replacing array with slots in tabbar component * fix number unit padding (#695) * fix number unit padding * refactored css * code formatting * cleanups * full width * split prepend case is done * fixed non split versions * turned on description again * fixed paddings, readonly and story property namings * updated branch --------- Co-authored-by: christian.b.hoffmann <[email protected]> Co-authored-by: Christian Hoffmann <[email protected]> * #534 numberinput renames tokens (#785) * renames numberinput.inputField.textWrapper.itemSpacing.. * updates ../number-input/index.css.ts * reset css.ts * token renamings --------- Co-authored-by: christian.b.hoffmann <[email protected]> * Updates token meta (#820) * minor * feat(storybook): add tooltip docs (#716) * feat(storybook): add tooltip bubble docs (#821) * Fix/578 counter state (#826) * fix(ui-library): renamed default to neutral * Fix/597 form label (#827) * fix(ui-library):fix label padding --------- Co-authored-by: Barkley <[email protected]> Co-authored-by: Barkley <[email protected]> * Documentation Form Caption Component (#717) Co-authored-by: Christian Hoffmann <[email protected]> * fix(ui-library): fixed checked state (#803) Co-authored-by: manuel.seemann <[email protected]> Co-authored-by: Christian Hoffmann <[email protected]> * #770 stepper rename tokens (#828) * renames stepper tokens * reasign divider container color * renames stepper combo tokens * renames commbo divider padding tokens * updates stepper css2 * updates number input css & deletes foundation/.../action.css * adds stepperButton backgound and icon color * adds stepper icon size tokens * minor * updates border * fix border token * update css * fix disabled * mv tokens Action/Menu -> Actions/Menu (#839) * updates menu tokens (#840) * Fix/number input (#841) * fix(ui-library): number input bug fixes * Fix/772 dialog rename tokens (#842) * renames dialog tokens * add typo and textcolor to dialog * minor * fix error handling (#844) * Renames tokens: Action -> Actions (#843) * Tokens: replaces all Action/... with Actions/... * fix css by replacing Action with Actions * fix getComponentConfigToken params * Fix/rename focused tokens (#847) * renames focused -> focus * minor * fix css focused -> focus * feat:Create SECURITY.md (#848) Signed-off-by: Thorben Hartmann <[email protected]> * feature/428-feedback-form (#846) * feat:create bug_report.yaml Signed-off-by: Thorben Hartmann <[email protected]> * fix:Update bug_report.yaml Signed-off-by: Thorben Hartmann <[email protected]> * feat:Delete .github/ISSUE_TEMPLATE/custom-bug-template.md Signed-off-by: Thorben Hartmann <[email protected]> * feat:Create feature_request.yaml Signed-off-by: Thorben Hartmann <[email protected]> * fix:Rename bug_report.yaml to 1_bug_report.yaml Signed-off-by: Thorben Hartmann <[email protected]> * fix:Rename feature_request.yaml to 2_feature_request.yaml Signed-off-by: Thorben Hartmann <[email protected]> * feat:Update and rename custom.md to 3_custom_issue.yaml Signed-off-by: Thorben Hartmann <[email protected]> * feat:Create config.yaml Signed-off-by: Thorben Hartmann <[email protected]> * fix:Update config.yaml Signed-off-by: Thorben Hartmann <[email protected]> * fix:Update 1_bug_report.yaml Signed-off-by: Thorben Hartmann <[email protected]> * fix:Update 2_feature_request.yaml Signed-off-by: Thorben Hartmann <[email protected]> * fix:Update 3_custom_issue.yaml Signed-off-by: Thorben Hartmann <[email protected]> * feat:Create SUPPORT.md Signed-off-by: Thorben Hartmann <[email protected]> --------- Signed-off-by: Thorben Hartmann <[email protected]> * Feature/428 fix feedback form (#850) * fix:Rename config.yaml to config.yml Signed-off-by: Thorben Hartmann <[email protected]> * fix:Update 1_bug_report.yaml Signed-off-by: Thorben Hartmann <[email protected]> --------- Signed-off-by: Thorben Hartmann <[email protected]> * Fix/790 improve padding naming (#851) * renames paddingTopBottom and paddingLeftRight tokens * fix tooltip padding token * fix css and other minor * rmv token: Actions.BorderRadius * fix menu...borderRadius * minor * Feat/845 improve token structure (#853) * new config * update config * fix styledictionary.config * Fix/597 form label padding (#855) * feat(ui-library): adding label wrapper to each consuming component and applying padding * Feature/366 getstarted documentation (#857) * fix:Update 3_custom_issue.yaml Signed-off-by: Thorben Hartmann <[email protected]> * fix:Update 3_custom_issue.yaml Signed-off-by: Thorben Hartmann <[email protected]> * feature:Update GETSTARTED.md Signed-off-by: Thorben Hartmann <[email protected]> * feature:Update GETSTARTED.md Signed-off-by: Thorben Hartmann <[email protected]> --------- Signed-off-by: Thorben Hartmann <[email protected]> Co-authored-by: David Kennedy <[email protected]> * fix:Update README.md (#861) Signed-off-by: Thorben Hartmann <[email protected]> * fix/Update README.md (#862) Signed-off-by: Thorben Hartmann <[email protected]> * feat(storybook): delete react folder (#836) * feat(storybook): delete react folder * fix(ui-library): centering tooltip bubble text (#856) * docs:Update GETSTARTED.md (#882) Added bullet about sales deck in project management checklist Signed-off-by: Thorben Hartmann <[email protected]> * docs:Update README.md (#888) - fixed downloadlink to figma file - removed issues & bugs section, as the new sections under help & feedback, which we added as part of #428 are way more detailed and have a better user-flow Signed-off-by: Thorben Hartmann <[email protected]> * fix: fixing readme file with updated figma file links (#889) * added tooltip to example app and fixed offset (#837) Co-authored-by: David Kennedy <[email protected]> * fix(storybook): adjust component size (#881) * fix(storybook): adjust component size * fix(ui): change sm border width --------- Co-authored-by: Thorben Hartmann <[email protected]> * fix(ui): add eventListeners to textarea (#485) (#885) * docs:Update PROJECTBACKGROUND.md (#892) * docs:Update PROJECTBACKGROUND.md - filled out projectbackground template Signed-off-by: Thorben Hartmann <[email protected]> * fix:Update PROJECTBACKGROUND.md fixed a typo Signed-off-by: Thorben Hartmann <[email protected]> --------- Signed-off-by: Thorben Hartmann <[email protected]> * fix(884): loading status property remocal from loader component (#887) * Fix/form caption accessibility (#893) * fix(ui-library): removing aria-label from form caption group --------- Co-authored-by: christian.b.hoffmann <[email protected]> * docs:Update GETSTARTED.md (#900) Added pre-refinement to meetings Signed-off-by: Thorben Hartmann <[email protected]> * fix(ui): add eventListeners to textinput (#482) (#890) * fix(ui-library): removing aria-label from form caption group --------- docs:Update GETSTARTED.md (#900) Added pre-refinement to meetings Signed-off-by: Thorben Hartmann <[email protected]> * fix(all): use new name of lit-analyzer extension in vs code recommendations (#906) * docs:Update README.md (#914) added a missing word Signed-off-by: Thorben Hartmann <[email protected]> * fix(ui): adjust naming in documentation of icon (#879) (#905) * consistency property naming between code and documentation for divider (#874) (#896) * fix(ui-library): textarea label space alignment and counter alignment (#907) * fix(882): textarea label space alignment and counter alignment * yarn lock reverted * feature(storybook): change folder structure (#894) * feature(storybook): change folder structure * fix(storybook): change imports for types * fix(storybook): wip * only create custom element if not defined * feat(storybook): align overall folder structure * fix(storybook): tests * fix(storybook): delete unnecessary folder * fix(storybook): wip * fix(storybook): delete double customElements --------- Co-authored-by: christian.b.hoffmann <[email protected]> * fix(storybook): clean up (#925) * fix(ui-library): number input accessibility (#917) * fix(ui-library): add aria labels to number input steppers * fix(ui-library): render form labels and inputs in same shadow dom to preserve "for" relation * fix(ui-library): set theme text color for number input and fix theme toggle * fix:Update CONTRIBUTING.md (#863) Added "fix" as a valid feature branch, as discussed today with the team. Signed-off-by: Thorben Hartmann <[email protected]> * docs: Update GETSTARTED.md (#898) Co-authored-by: David Kennedy <[email protected]> * Feat/606 storybook badges (#930) * feature(ui-library): added storybook badges addon and customized it * docs(general):Update CONTRIBUTING.md (#934) - changed title to "Contributing" and combined intro sections above "Content" - added icons to main section titles and Content - removed B01LER Monthly, as it is already mentioned in README Signed-off-by: Thorben Hartmann <[email protected]> * fix(ui): adjust naming in documentation of textarea (#485) (#885) (#895) * feat(ui-library): rename change events and move event code to global file * feat(ui-library): rename change events to prepare for exact types * refactor(ui-library): move event code and types to global file # Conflicts: # packages/ui-library/src/components/checkbox/index.ts # packages/ui-library/src/components/select/index.ts # packages/ui-library/src/components/text-input/index.ts # packages/ui-library/src/components/textarea/index.ts * fix(documentation): create testing documentation (#371) (#928) * fix(icons): auto generated icon type needs const array (#929) * Fix/645 add unit tests for slots (#903) * fix(ui-library): adding unit tests for components using slots * fix(877): Ensure Consistency between Storybook Documentation and Codebase (#941) * fix/866-ensure-consistency-property-names (#891) * fix(ui-library): harmonized property naming in iconButton * fix(781):Ensure Consistency between Storybook Documentation and Codebase Property Names (#939) * Fix/867 ensure property naming text button (#935) * fix(ui-library): harmonized property naming in textButton and all relevant files * fix/867a-ensure-property-naming-text-button (#944) * fix(ui-library): added some changes after review * fix(ui-library): adapted action property naming in the story * fix(ui-library): harmonized naming in argTypes * fix(ui): fix textarea accessibility violation (#777) (#919) * fix(ui-library): props alignment button group (#948) * docs(fix): rename doc to docs (#951) * - renamed doc folder to docs - updated links between documentation files - updated "Get Started" section in CONTRIBUTING file * docs: fix typos * docs: remove empty lines Signed-off-by: Thorben Hartmann <[email protected]> * docs: remove empty lines and premature sentence wrapping Signed-off-by: Thorben Hartmann <[email protected]> * docs: removing new line and sentence wrapping Signed-off-by: Thorben Hartmann <[email protected]> * docs: remove new lines and sentence wrapping Signed-off-by: Thorben Hartmann <[email protected]> * docs: remove new lines Signed-off-by: Thorben Hartmann <[email protected]> * docs: remove new lines Signed-off-by: Thorben Hartmann <[email protected]> * docs: remove new lines Signed-off-by: Thorben Hartmann <[email protected]> * docs: remove new lines Signed-off-by: Thorben Hartmann <[email protected]> * docs: remove empty lines Signed-off-by: Thorben Hartmann <[email protected]> * docs: remove empty lines Signed-off-by: Thorben Hartmann <[email protected]> --------- Signed-off-by: Thorben Hartmann <[email protected]> * docs(general):Update ARCHITECTURE.md file (#950) * 735-update-renamed-repo-links (#955) * docs(README): update image link Signed-off-by: Thorben Hartmann <[email protected]> * docs: update repo links Signed-off-by: Thorben Hartmann <[email protected]> * docs: update repo links Signed-off-by: Thorben Hartmann <[email protected]> * docs: update repo links Signed-off-by: Thorben Hartmann <[email protected]> * docs: update repo links Signed-off-by: Thorben Hartmann <[email protected]> * docs: update repo links Signed-off-by: Thorben Hartmann <[email protected]> --------- Signed-off-by: Thorben Hartmann <[email protected]> * Feat/improve token structure v3 (#946) * Feat(tokens): applied tokenchanges from v2 * updated tokens * try fix tokens:generate on CI * try fix tokens:generate on CI * made gitignore not needing to know theme names * try fix tokens:generate on CI * try fix tokens:generate on CI * all folders lower case * fix number names --------- Co-authored-by: larserbach <[email protected]> * Feature/564 new figma release (#956) * docs: update figma links for new release Signed-off-by: Thorben Hartmann <[email protected]> * docs: update figma link Signed-off-by: Thorben Hartmann <[email protected]> --------- Signed-off-by: Thorben Hartmann <[email protected]> * docs: fix figma link (#957) Signed-off-by: Thorben Hartmann <[email protected]> --------- Signed-off-by: Thorben Hartmann <[email protected]> Co-authored-by: kaikdi <[email protected]> Co-authored-by: Christian Hoffmann <[email protected]> Co-authored-by: Usman <[email protected]> Co-authored-by: Muhammad Usman <[email protected]> Co-authored-by: JpunktWpunkt <[email protected]> Co-authored-by: David Kennedy <[email protected]> Co-authored-by: larserbach <[email protected]> Co-authored-by: m-nti <[email protected]> Co-authored-by: RubirajAccenture <[email protected]> Co-authored-by: Barkley <[email protected]> Co-authored-by: David Kennedy <[email protected]> Co-authored-by: christian.b.hoffmann <[email protected]> Co-authored-by: Barkley <[email protected]> Co-authored-by: Manuel Seemann <[email protected]> Co-authored-by: manuel.seemann <[email protected]> Co-authored-by: Ang Dawa Sherpa <[email protected]> Co-authored-by: Remmy Cat Stock <[email protected]> Co-authored-by: Roman Yakovliev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #371