Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-library): text input-ensure consistency between storybook documentation and property names #1017

Merged
merged 3 commits into from
Mar 22, 2024
Merged

fix(ui-library): text input-ensure consistency between storybook documentation and property names #1017

merged 3 commits into from
Mar 22, 2024

Conversation

RubirajAccenture
Copy link
Contributor

@RubirajAccenture RubirajAccenture commented Mar 13, 2024 •
edited by thrbnhrtmnn
Loading

closes #864

@RubirajAccenture RubirajAccenture changed the title fix(864): Text Input - Ensure Consistency between Storybook Documentation and Codebase Property Names fix(ui-library): Text Input - Ensure Consistency between Storybook Documentation and Codebase Property Names Mar 13, 2024
@RubirajAccenture RubirajAccenture changed the title fix(ui-library): Text Input - Ensure Consistency between Storybook Documentation and Codebase Property Names fix(ui-library): text input - ensure consistency between storybook documentation and codebase property names Mar 13, 2024
@RubirajAccenture RubirajAccenture force-pushed the fix-prop-alignment-textinput branch from 94b6c43 to cd52cc9 Compare March 13, 2024 13:50
@RubirajAccenture RubirajAccenture changed the title fix(ui-library): text input - ensure consistency between storybook documentation and codebase property names fix(ui-library):text input-ensure consistency between storybook documentation and property names Mar 14, 2024
@RubirajAccenture RubirajAccenture changed the title fix(ui-library):text input-ensure consistency between storybook documentation and property names fix(ui-library): text input-ensure consistency between storybook documentation and property names Mar 14, 2024
thrbnhrtmnn
thrbnhrtmnn reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@thrbnhrtmnn thrbnhrtmnn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RubirajAccenture apart from davids comment and the conflicts that need to be resolved I would also like you to fix the order of all props in the props panel in the stories.ts.

The order should be exactly as in the Props Excel (with "theme" on top within the Appearance section):
sizeVariant
type
placeholder
value
maxLength
hasLabel
(hasLabel) -> label
(hasLabel) -> labelAppendix
hasIcon
(hasIcon) -> icon
hasHint
(hasHint) -> hintMessage
(hasHint) -> hintMessageIcon
disabled
readonly
required
hasError
(hasError) -> errorMessage
(hasError) -> errorMessageIcon
ariaLabel
[componentName]Id
name
blrTextValueChange
blrSelect
blrFocus
blrBlur

@RubirajAccenture RubirajAccenture force-pushed the fix-prop-alignment-textinput branch from 0a1287d to f40db60 Compare March 15, 2024 09:14
@RubirajAccenture RubirajAccenture force-pushed the fix-prop-alignment-textinput branch from f40db60 to 33f7ba6 Compare March 15, 2024 09:16
thrbnhrtmnn
thrbnhrtmnn requested changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@thrbnhrtmnn thrbnhrtmnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RubirajAccenture , please update the order of the props in the props panel, according to the Excel / my last comment.

Once this is done I can approve :-)

@RubirajAccenture RubirajAccenture force-pushed the fix-prop-alignment-textinput branch from 388b6e8 to 7d4aca2 Compare March 20, 2024 13:20
angsherpa456
angsherpa456 previously approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@angsherpa456 angsherpa456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thrbnhrtmnn
thrbnhrtmnn requested changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@thrbnhrtmnn thrbnhrtmnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RubirajAccenture , just one small fix needed:

Please change the order of the "name" and the "inputFieldTextId" props in the prop panel. "inputFieldTextId" should come first, then "name".

@RubirajAccenture RubirajAccenture force-pushed the fix-prop-alignment-textinput branch from 7d4aca2 to 66ed958 Compare March 21, 2024 09:14
angsherpa456
angsherpa456 approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@angsherpa456 angsherpa456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RubirajAccenture RubirajAccenture merged commit 30a5b38 into develop Mar 22, 2024
4 of 5 checks passed
@RubirajAccenture RubirajAccenture deleted the fix-prop-alignment-textinput branch March 22, 2024 09:34
ChristianHoffmannS2 pushed a commit that referenced this pull request Mar 26, 2024
@RubirajAccenture @ChristianHoffmannS2
fix(ui-library): text input-ensure consistency between storybook docu…
d94056a 
…mentation and property names (#1017)

* fix(864): Text Input - Ensure Consistency between Storybook Documentation and Codebase Property Names

* fix(ui-library): comments removed
ChristianHoffmannS2 pushed a commit that referenced this pull request Mar 26, 2024
@RubirajAccenture @ChristianHoffmannS2
fix(ui-library): text input-ensure consistency between storybook docu…
e9747d8 
…mentation and property names (#1017)

* fix(864): Text Input - Ensure Consistency between Storybook Documentation and Codebase Property Names

* fix(ui-library): comments removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrbnhrtmnn thrbnhrtmnn thrbnhrtmnn approved these changes

@angsherpa456 angsherpa456 angsherpa456 approved these changes

@JpunktWpunkt JpunktWpunkt Awaiting requested review from JpunktWpunkt

@davidken91 davidken91 Awaiting requested review from davidken91

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text Input - Ensure Consistency between Storybook Documentation and Codebase Property Names
4 participants
@RubirajAccenture @angsherpa456 @thrbnhrtmnn @davidken91