adds ability to export non-EPSG CRSs URIs #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d code from the CRS directly
|
okay so I know that the None object is most likely due to the too-high confidence level default to the to_authority call, although I can't seem to find much information on why proj doesn't always have high confidence, is there information missing from the CRS of that polar projection? |
|
okay so although tests (mostly) pass, I am going to add back a check to ensure we don't try to unpack a None to allow for cases when the right answer really is EPSG/0/None |
…he authority don't raise an exception
AndrewAnnex
changed the title
|
@vincentsarago I've added a test (one parameterized test per authority, not checking every code) and fixed remaining black formatting issues. I could see adding a test to try to ensure that EPSG/0/None is at least returned sometimes, your call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grabs the authority, version and code from the CRS directly to encode the URIs. Related to #92 but can be merged separately. I'm not aware of any issues this would cause but I am open to hearing about them