Skip to content

Commit

Permalink
lint
Browse files Browse the repository at this point in the history
  • Loading branch information
kylebarron committed Nov 28, 2023
1 parent 6a90a00 commit 763b460
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
2 changes: 1 addition & 1 deletion docs/alternatives.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Aside from this, pydeck and lonboard use different widget architectures. Pydeck

## Lonboard vs kepler.gl-jupyter

[kepler.gl](https://kepler.gl/) is a JavaScript application focused on presenting a simple, high-level visualization and analysis toolkit to browser-based users. It also has Python bindings via [kepler.gl-jupyter](https://docs.kepler.gl/docs/keplergl-jupyter).
[kepler.gl](https://kepler.gl/) is a JavaScript application focused on presenting a simple, high-level visualization and analysis toolkit to browser-based users. Just like Lonboard, it's built on top of [deck.gl](https://deck.gl). It also has Python bindings via [kepler.gl-jupyter](https://docs.kepler.gl/docs/keplergl-jupyter).

kepler.gl is a very good tool for data analysis and exploration _in the browser_. On the contrary, Lonboard targets users who plan to do most analysis in Python, but want the best performance to visualize the maximum amount of data. Lonboard should have better rendering performance, but has no user interface to analyze data _in the browser_.

Expand Down
12 changes: 8 additions & 4 deletions src/model/layer.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
import type { Layer, LayerExtension, LayerProps, PickingInfo } from "@deck.gl/core/typed";
import type {
Layer,
LayerExtension,
LayerProps,
PickingInfo,
} from "@deck.gl/core/typed";
import {
GeoArrowArcLayer,
GeoArrowArcLayerProps,
Expand All @@ -8,7 +13,6 @@ import {
GeoArrowHeatmapLayerProps,
GeoArrowPathLayer,
GeoArrowPathLayerProps,
GeoArrowPickingInfo,
GeoArrowScatterplotLayer,
GeoArrowScatterplotLayerProps,
GeoArrowSolidPolygonLayer,
Expand Down Expand Up @@ -165,8 +169,8 @@ export class ArcModel extends BaseLayerModel {
protected widthScale: GeoArrowArcLayerProps["widthScale"] | null;
protected widthMinPixels: GeoArrowArcLayerProps["widthMinPixels"] | null;
protected widthMaxPixels: GeoArrowArcLayerProps["widthMaxPixels"] | null;
protected getSourcePosition!: GeoArrowArcLayerProps["getSourcePosition"]
protected getTargetPosition!: GeoArrowArcLayerProps["getTargetPosition"]
protected getSourcePosition!: GeoArrowArcLayerProps["getSourcePosition"];
protected getTargetPosition!: GeoArrowArcLayerProps["getTargetPosition"];
protected getSourceColor: GeoArrowArcLayerProps["getSourceColor"] | null;
protected getTargetColor: GeoArrowArcLayerProps["getTargetColor"] | null;
protected getWidth: GeoArrowArcLayerProps["getWidth"] | null;
Expand Down

0 comments on commit 763b460

Please sign in to comment.