Use preact Fragment to render multiple children #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `wrap = true`, `preact-markup` only renders the first child. Using Fragments, `preact-markup` can render all the children without wrapping them with a `<div />`.
|
@developit Would you mind merging this? |
|
@developit @marvinhagemeister what do you think of this PR? |
developit
requested changes
Apr 22, 2020
src/index.js
Outdated
| @@ -49,7 +49,7 @@ export default class Markup extends Component { | |||
| } | |||
| } | |||
|
|
|||
| if (wrap===false) return vdom && vdom[0] || null; | |||
| if (wrap===false) return vdom && h(Fragment, {}, vdom) || null; | |||
There was a problem hiding this comment.
There's no need for Fragment here - this line can just return the array:
if (wrap===false) return vdom || null;
|
Good idea! I left a suggestion to simplify things. I'm actually thinking we can just drop the wrap parameter now, since this component can just always return the array of elements. |
|
Thanks @developit! I applied your suggestion. For backwards compatibility, maybe we can keep the |
|
@hpneo yeah that works for me! |
developit
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
wrap = true,preact-markuponly renders the first child. Using Fragments,preact-markupcan render all the children without wrapping them with a<div />.