Pipe uncought parse errors (e.g.: no onError defined) to the browse…

…r console. Fixes #4.
developit · May 25, 2016 · 50e049b · 50e049b
1 parent e708952
commit 50e049b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/index.js b/src/index.js
@@ -38,8 +38,13 @@ export default class Markup extends Component {
 
 		try {
 			vdom = markupToVdom(markup, type, h, this.map, options);
-			if (onError) onError({ error });
 		} catch (error) {
+			if (onError) {
+				onError({ error });
+			}
+			else if (typeof console!=='undefined' && console.error) {
+				console.error(`preact-markup: ${error}`);
+			}
 		}
 
 		if (wrap===false) return vdom && vdom[0] || null;

diff --git a/test/index.js b/test/index.js
@@ -203,4 +203,16 @@ describe('Markup', () => {
 			element.dispatchEvent(ev);
 		});
 	});
+
+	it('should pipe parse errors to console', () => {
+		sinon.spy(console, 'error');
+
+		let invalidXml = `<h1>Test with & symbol</h1>`;
+
+		render(<Markup markup={invalidXml} />, scratch);
+
+		expect(console.error)
+			.to.have.been.calledOnce
+			.and.calledWithMatch('preact-markup: Error: error on line 2 at column 21: xmlParseEntityRef: no name');
+	});
 });