Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Added searchbar transition #82

Closed
wants to merge 1 commit into from
Closed

[WIP] Added searchbar transition #82

wants to merge 1 commit into from

Conversation

parthsujalshah
Copy link
Collaborator

Added the transition effect in the search bar. It just needs to be positioned at the center

@jsparmani jsparmani changed the title added searchbar transition [WIP] Added searchbar transition May 23, 2020
@jsparmani jsparmani linked an issue May 23, 2020 that may be closed by this pull request
Change UI Home Page [Search Bar] #78
Open
@jsparmani jsparmani requested a review from aniketbiswas21 May 23, 2020 18:49
@jsparmani jsparmani added bug Something isn't working frontend labels May 23, 2020
@kush-daga
Copy link
Member

Whats going on with this? Status?

@jsparmani
Copy link
Member

Whats going on with this? Status?

The homepage is ready, improvisations on the scroll transition going on

@jsparmani
Copy link
Member

@kush-daga can u review the home page once

@kush-daga
Copy link
Member

Okay ill check

@kush-daga
Copy link
Member

Its fine for now, there are some style changes that needs to be done, but ill do that after this gets merged.

aniketbiswas21
aniketbiswas21 requested changes May 24, 2020
View reviewed changes
Copy link
Member

@aniketbiswas21 aniketbiswas21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transition seems fine but we need to center the search bar on scroll and ThaparX has to disappear when scrolled. Also the Topbar needs to be fixed at one place. I wasn't able to do that.

@jsparmani
Copy link
Member

The transition seems fine but we need to center the search bar on scroll and ThaparX has to disappear when scrolled. Also the Topbar needs to be fixed at one place. I wasn't able to do that.

@aniketbiswas21 can u give this a try in the updates that @parthsujalshah has made.

@aniketbiswas21
Copy link
Member

Sure @jsparmani

@jsparmani
Copy link
Member

Sure @jsparmani

@aniketbiswas21 Is the center positioning fixed now..or ur still facing some issue doing it?

@aniketbiswas21
Copy link
Member

@jsparmani still working

@jsparmani
Copy link
Member

@all-contributors please add @parthsujalshah for code

@allcontributors allcontributors bot mentioned this pull request Jun 2, 2020
Merged
@allcontributors
Copy link
Contributor

@jsparmani

I've put up a pull request to add @parthsujalshah! 🎉

@jsparmani
Copy link
Member

@all-contributors please add @aniketbiswas21 for code, design

@allcontributors allcontributors bot mentioned this pull request Jun 2, 2020
Merged
@allcontributors
Copy link
Contributor

@jsparmani

I've put up a pull request to add @aniketbiswas21! 🎉

@jsparmani
Copy link
Member

@all-contributors please add @Saurav-Shrivastav for code

@allcontributors allcontributors bot mentioned this pull request Jun 2, 2020
Merged
@allcontributors
Copy link
Contributor

@jsparmani

I've put up a pull request to add @Saurav-Shrivastav! 🎉

@jsparmani
Copy link
Member

@all-contributors please add @kush-daga for code, design

@allcontributors allcontributors bot mentioned this pull request Jun 2, 2020
Merged
@allcontributors
Copy link
Contributor

@jsparmani

I've put up a pull request to add @kush-daga! 🎉

@jsparmani
Copy link
Member

@all-contributors please add @jakebolam for code, maintenance, tests, docs

@allcontributors allcontributors bot mentioned this pull request Jun 2, 2020
Closed
@allcontributors
Copy link
Contributor

@jsparmani

I've put up a pull request to add @jakebolam! 🎉

@jsparmani
Copy link
Member

@all-contributors please add @jsparmani for code, maintenance, tests, docs

@allcontributors allcontributors bot mentioned this pull request Jun 2, 2020
Merged
@allcontributors
Copy link
Contributor

@jsparmani

I've put up a pull request to add @jsparmani! 🎉

@jsparmani
Copy link
Member

@all-contributors please add @shubhank-saxena for tests, docs

@allcontributors allcontributors bot mentioned this pull request Jun 2, 2020
Merged
@allcontributors
Copy link
Contributor

@jsparmani

I've put up a pull request to add @shubhank-saxena! 🎉

@jsparmani
Copy link
Member

@all-contributors please add @shreyagupta30 for docs

@allcontributors allcontributors bot mentioned this pull request Jun 2, 2020
Merged
@allcontributors
Copy link
Contributor

@jsparmani

I've put up a pull request to add @shreyagupta30! 🎉

@jsparmani
Copy link
Member

@all-contributors please add @all-contributors for docs

@allcontributors allcontributors bot mentioned this pull request Jun 2, 2020
Merged
@allcontributors
Copy link
Contributor

@jsparmani

I've put up a pull request to add @all-contributors! 🎉

@jsparmani jsparmani closed this Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniketbiswas21 aniketbiswas21 aniketbiswas21 requested changes

Assignees

@parthsujalshah parthsujalshah

@aniketbiswas21 aniketbiswas21

Labels
bug Something isn't working frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change UI Home Page [Search Bar]
4 participants
@parthsujalshah @kush-daga @jsparmani @aniketbiswas21