New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Added searchbar transition #82

Closed

parthsujalshah wants to merge 1 commit into developer-student-club-thapar:master from parthsujalshah:searchbar-transition

Collaborator

parthsujalshah commented May 23, 2020

Added the transition effect in the search bar. It just needs to be positioned at the center


          added searchbar transition

f90b113

jsparmani changed the title ~~added searchbar transition~~ [WIP] Added searchbar transition

jsparmani linked an issue

that may be closed by this pull request

Change UI Home Page [Search Bar] #78

Open

jsparmani requested a review from aniketbiswas21

May 23, 2020 18:49

jsparmani assigned parthsujalshah and aniketbiswas21

jsparmani added bug frontend labels

Member

kush-daga commented May 23, 2020

Whats going on with this? Status?

Member

jsparmani commented May 23, 2020

Whats going on with this? Status?

The homepage is ready, improvisations on the scroll transition going on

Member

jsparmani commented May 23, 2020

@kush-daga can u review the home page once

Member

kush-daga commented May 23, 2020

Okay ill check

Member

kush-daga commented May 23, 2020

Its fine for now, there are some style changes that needs to be done, but ill do that after this gets merged.

aniketbiswas21 requested changes

View reviewed changes

Member

aniketbiswas21 left a comment

The transition seems fine but we need to center the search bar on scroll and ThaparX has to disappear when scrolled. Also the Topbar needs to be fixed at one place. I wasn't able to do that.

Member

jsparmani commented May 26, 2020

The transition seems fine but we need to center the search bar on scroll and ThaparX has to disappear when scrolled. Also the Topbar needs to be fixed at one place. I wasn't able to do that.

@aniketbiswas21 can u give this a try in the updates that @parthsujalshah has made.

Member

aniketbiswas21 commented May 27, 2020

Sure @jsparmani

Member

jsparmani commented May 27, 2020

Sure @jsparmani

@aniketbiswas21 Is the center positioning fixed now..or ur still facing some issue doing it?

Member

aniketbiswas21 commented May 28, 2020

@jsparmani still working

Member

jsparmani commented Jun 2, 2020

@all-contributors please add @parthsujalshah for code

allcontributors bot mentioned this pull request

docs: add parthsujalshah as a contributor #100

Merged

Contributor

allcontributors bot commented Jun 2, 2020

I've put up a pull request to add @parthsujalshah! 🎉

Member

jsparmani commented Jun 2, 2020

@all-contributors please add @aniketbiswas21 for code, design

allcontributors bot mentioned this pull request

docs: add aniketbiswas21 as a contributor #101

Merged

Contributor

allcontributors bot commented Jun 2, 2020

I've put up a pull request to add @aniketbiswas21! 🎉

Member

jsparmani commented Jun 2, 2020

@all-contributors please add @Saurav-Shrivastav for code

allcontributors bot mentioned this pull request

docs: add Saurav-Shrivastav as a contributor #102

Merged

Contributor

allcontributors bot commented Jun 2, 2020

I've put up a pull request to add @Saurav-Shrivastav! 🎉

Member

jsparmani commented Jun 2, 2020

@all-contributors please add @kush-daga for code, design

allcontributors bot mentioned this pull request

docs: add kush-daga as a contributor #103

Merged

Contributor

allcontributors bot commented Jun 2, 2020

I've put up a pull request to add @kush-daga! 🎉

Member

jsparmani commented Jun 2, 2020

@all-contributors please add @jakebolam for code, maintenance, tests, docs

allcontributors bot mentioned this pull request

docs: add jakebolam as a contributor #104

Closed

Contributor

allcontributors bot commented Jun 2, 2020

I've put up a pull request to add @jakebolam! 🎉

Member

jsparmani commented Jun 2, 2020

@all-contributors please add @jsparmani for code, maintenance, tests, docs

allcontributors bot mentioned this pull request

docs: add jsparmani as a contributor #105

Merged

Contributor

allcontributors bot commented Jun 2, 2020

I've put up a pull request to add @jsparmani! 🎉

Member

jsparmani commented Jun 2, 2020

@all-contributors please add @shubhank-saxena for tests, docs

allcontributors bot mentioned this pull request

docs: add shubhank-saxena as a contributor #106

Merged

Contributor

allcontributors bot commented Jun 2, 2020

I've put up a pull request to add @shubhank-saxena! 🎉

Member

jsparmani commented Jun 2, 2020

@all-contributors please add @shreyagupta30 for docs

allcontributors bot mentioned this pull request

docs: add shreyagupta30 as a contributor #107

Merged

Contributor

allcontributors bot commented Jun 2, 2020

I've put up a pull request to add @shreyagupta30! 🎉

Member

jsparmani commented Jun 2, 2020

@all-contributors please add @all-contributors for docs

allcontributors bot mentioned this pull request

docs: add all-contributors as a contributor #108

Merged

Contributor

allcontributors bot commented Jun 2, 2020

I've put up a pull request to add @all-contributors! 🎉

jsparmani closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels