Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: improve code structure #2

Merged
merged 51 commits into from
Dec 4, 2021

Conversation

rickstaa
Copy link

@rickstaa rickstaa commented Dec 4, 2021

This pull request cleans up the code and makes sure the tests work.

abrj7 and others added 30 commits July 20, 2021 12:49
env name should be PAT_1, but on the picture is GITHUB_TOKEN
* feat: added option to hide languages

* feat: recalculate percentages for hidden languages

* refactor: reverted langs_count and did some formatting

* doc: added hide to readme

* feat: make languages var mutable and improve filter logic

Co-authored-by: Adrian Kunz <[email protected]>

* refactor: improve code and added tests

Co-authored-by: Adrian Kunz <[email protected]>
Co-authored-by: Anurag <[email protected]>
* feat(statCard): added more concise description

* fix: removed isLongLocale param

* Revert "fix: removed isLongLocale param"

This reverts commit 55f1e2d.

* feat: add de and nl to longLocal to fix padding
…#1314)

* feat(layout): improve flexLayout & fixed layout overlaps

* chore: fix vercel build
* refactor: refactored repo-card

* test: fix tests

* test: fixed tests

* fix: unprovided description error
* Match link with section title

Match the link of Top Languages Card with the title of his section ("Tarjeta de Lenguajes Principales").

* Fix typo
* Add Noctis minimus theme

* Add Noctis minimus theme

Co-authored-by: Anurag Hazra <[email protected]>
* Fix grammatical errors

* Fix grammatical errors
* fix: change serverless function memory to 128mb

* chore: change maxDuration
* refactor: jsdoc in utils & minor changes

* chore: jsdoc Card class

* chore: jsdoc for getStyles
Marcholio and others added 20 commits October 18, 2021 19:11
* Fixed word-wrap bug

* ci(workflow): add 'npm' cache for actions/setup-node in .github/workflows (anuraghazra#1382)

* Revert "ci(workflow): add 'npm' cache for actions/setup-node in .github/workflows (anuraghazra#1382)"

This reverts commit 2723f00.

* chore: remove action cache

* chore: minor change

Co-authored-by: Markus Tyrkkö <[email protected]>
Co-authored-by: Oscar Dominguez <[email protected]>
Co-authored-by: Anurag <[email protected]>
* docs: add fork instructions

* chore: revert toc
* feat: improved theme preview script

* chore: add getPRNumber
* chore: added ability upsert comments

* chore: new event
@vercel
Copy link

vercel bot commented Dec 4, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @developStorm on Vercel.

@developStorm first needs to authorize it.

@rickstaa
Copy link
Author

rickstaa commented Dec 4, 2021

@developStorm This is the pull request I intended in the first place. I now got once again remembered why it is so important to use clear distinct branch names.

@developStorm
Copy link
Owner

@rickstaa Would you mind to resolve the conflict before I can merge this?

@rickstaa
Copy link
Author

rickstaa commented Dec 4, 2021

@developStorm I just fixed it. Sorry again for the inconvenience.

@developStorm developStorm merged commit 4a4cec6 into developStorm:master Dec 4, 2021
@rickstaa rickstaa deleted the develop/master branch December 4, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.