Check whole hashbang line if it is /usr/bin/env #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would fix #63.
Because pnpm uses the hashbang
/usr/bin/env node
, only checking until the first space as is current done will miss thenode
.This change will only include the space if the text before the space is "/usr/bin/env", so that it doesn't break any existing code (
/usr/bin/env
would fail the check anyway)This fix is working in my minimum reproduction of the issue (the Test stage)
Running it in the original repository that I found the bug in, it is getting past where it got before (it doesn't get the %1 is not a valid command error) but now at the end of the postinstall it gets another error (Install & Build stage):
I'm not sure if that is caused by this change or not though, because there is no ground truth to compare to.