Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolve all the pnpm issues without hostied config #136

Merged
merged 7 commits into from
Sep 15, 2024

Conversation

beyondkmp
Copy link
Contributor

@beyondkmp beyondkmp commented Sep 15, 2024

In this PR(#132), only the case of files with the same name has been fixed. If it's not a file but a folder, and there's a package.json inside, it will lead to obtaining the wrong package.

Therefore, FindParentWithFile is incorrect. It shouldn't directly search upwards, as searching upwards can result in finding packages outside of node_modules.

To implement the non-hoisted mode under pnpm, we just need to replace the dir in the dependency with the actual dir.

dependency.dir = resolvePath(dependencyDir)

Combined with the hoisted conversion algorithm in this MR(#134), it can solve the issues mentioned below.

fix:
#84
#92
#93

Copy link

changeset-bot bot commented Sep 15, 2024

🦋 Changeset detected

Latest commit: f2c9989

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
app-builder-bin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmaietta mmaietta merged commit bbad893 into develar:master Sep 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants