feat: resolve all the pnpm issues without hostied config #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR(#132), only the case of files with the same name has been fixed. If it's not a file but a folder, and there's a package.json inside, it will lead to obtaining the wrong package.
Therefore, FindParentWithFile is incorrect. It shouldn't directly search upwards, as searching upwards can result in finding packages outside of node_modules.
To implement the non-hoisted mode under pnpm, we just need to replace the dir in the dependency with the actual dir.
app-builder/pkg/node-modules/nodeModuleCollector.go
Line 299 in 82d3a96
Combined with the hoisted conversion algorithm in this MR(#134), it can solve the issues mentioned below.
fix:
#84
#92
#93