Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set fixed width on button with responsive adjustment #330

Merged
merged 4 commits into from
Apr 21, 2024

Conversation

jsc215
Copy link
Contributor

@jsc215 jsc215 commented Apr 7, 2024

What issue is this referencing?

this fixes #321

Do these code changes work locally and have you tested that they fix the issue yourself?

  • [x ] yes!

Does the following command run without warnings or errors?

  • [ x] yes! npm run pr-checks

Have you taken a look at our contributing guidelines?

  • [ x] yes!

My node version matches the one suggested when running nvm use?

  • [ x] yes!

@MandyMeindersma
Copy link
Contributor

Thanks so much @jsc215 ! I love it.

I think we must have configured our linter weird, so I want to try to change it before we merge this in (we just changed to a new linting method, thank you for being our guinea pig). Unless this is your editors linting?

I am not on my machine until Tuesday though (going to view the eclipse! 🌞 ) so it might be until then until I can debug. Sorry!

@arashsheyda
Copy link
Collaborator

@jsc215 great work, thanks!

@MandyMeindersma the stylistic of eslint module is false by default (I thought it was true by default, sorry) I'll open a PR asap and after that we can merge this PR.

@jsc215
Copy link
Contributor Author

jsc215 commented Apr 7, 2024

@jsc215 great work, thanks!

@MandyMeindersma the stylistic of eslint module is false by default (I thought it was true by default, sorry) I'll open a PR asap and after that we can merge this PR.

you're very welcome!

@MandyMeindersma
Copy link
Contributor

Thanks to @arashsheyda our linting should be fixed now!

I think if you run npm run lint:fix it should auto fix? but if now maybe copy your changes to a new branch! Thanks again for being our guinea pig @jsc215

@MandyMeindersma
Copy link
Contributor

Hey @jsc215 I would still love to have your contribution so if you want to run the linting command that would be great, other wise I will merge this into another branch and then commit the linting errors then merge that (that way we still have your commit and work recorded!) 😄

@MandyMeindersma MandyMeindersma merged commit e5d1ff9 into devedmonton:main Apr 21, 2024
5 checks passed
@MandyMeindersma
Copy link
Contributor

@arashsheyda saved us again with the auto linting bot! Thank you

@allcontributors add @jsc215 for code

Copy link
Contributor

@MandyMeindersma

I've put up a pull request to add @jsc215! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Width of button is a little off
3 participants