-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set fixed width on button with responsive adjustment #330
set fixed width on button with responsive adjustment #330
Conversation
Thanks so much @jsc215 ! I love it. I think we must have configured our linter weird, so I want to try to change it before we merge this in (we just changed to a new linting method, thank you for being our guinea pig). Unless this is your editors linting? I am not on my machine until Tuesday though (going to view the eclipse! 🌞 ) so it might be until then until I can debug. Sorry! |
@jsc215 great work, thanks! @MandyMeindersma the stylistic of eslint module is false by default (I thought it was true by default, sorry) I'll open a PR asap and after that we can merge this PR. |
you're very welcome! |
Thanks to @arashsheyda our linting should be fixed now! I think if you run |
Hey @jsc215 I would still love to have your contribution so if you want to run the linting command that would be great, other wise I will merge this into another branch and then commit the linting errors then merge that (that way we still have your commit and work recorded!) 😄 |
@arashsheyda saved us again with the auto linting bot! Thank you @allcontributors add @jsc215 for code |
I've put up a pull request to add @jsc215! 🎉 |
What issue is this referencing?
this fixes #321
Do these code changes work locally and have you tested that they fix the issue yourself?
Does the following command run without warnings or errors?
npm run pr-checks
Have you taken a look at our contributing guidelines?
My node version matches the one suggested when running
nvm use
?