-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[desktop-lite] Suggested usage of appPort instead of forwardPorts for devconatiner-cli #1086
[desktop-lite] Suggested usage of appPort instead of forwardPorts for devconatiner-cli #1086
Conversation
… devcontainer-cli
Hi @bamurtaugh, here is the small documentation change you asked for in this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much!
Ah I think I misunderstood how the |
Ah thanks for catching this 😄 - @samruddhikhandale would you be able to help advise? |
Oops 😅 Once this PR got merged, https://github.com/devcontainers/action ran automatically ; which updated the README file based on Hence, @daniel-meilak can we make the same changes to |
Hey @samruddhikhandale, here you go, hopefully this time the change persists 😄 |
Left a minor comment, thank you @daniel-meilak |
Nice spot, I've accepted the suggestions |
Update to the
desktop-lite
usage documentation:The
devcontainer-cli
does not yet support the usage offorwardPorts
, as indicated here. Conveniently, we can still useappPort
in a similar manner.This PR simply adds a line of documentation to the
README
to make users aware of this difference.