Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[desktop-lite] Suggested usage of appPort instead of forwardPorts for devconatiner-cli #1086

Conversation

daniel-meilak
Copy link
Contributor

@daniel-meilak daniel-meilak commented Aug 11, 2024

Update to the desktop-lite usage documentation:
The devcontainer-cli does not yet support the usage of forwardPorts, as indicated here. Conveniently, we can still use appPort in a similar manner.

This PR simply adds a line of documentation to the README to make users aware of this difference.

@daniel-meilak
Copy link
Contributor Author

Hi @bamurtaugh, here is the small documentation change you asked for in this issue.

Copy link
Member

@bamurtaugh bamurtaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@bamurtaugh bamurtaugh merged commit 6d2b646 into devcontainers:main Aug 12, 2024
1 check passed
@daniel-meilak
Copy link
Contributor Author

daniel-meilak commented Aug 12, 2024

Ah I think I misunderstood how the README is generated. The Automated documentation update undid my change 😆, should I create a new PR that edits NOTES.md instead ?

@bamurtaugh
Copy link
Member

Ah thanks for catching this 😄 - @samruddhikhandale would you be able to help advise?

@daniel-meilak daniel-meilak deleted the desktop-lite-document-appPort-for-devcontainer-cli branch August 12, 2024 17:48
@daniel-meilak daniel-meilak restored the desktop-lite-document-appPort-for-devcontainer-cli branch August 12, 2024 17:49
@samruddhikhandale
Copy link
Member

Oops 😅

Once this PR got merged, https://github.com/devcontainers/action ran automatically ; which updated the README file based on devcontainer-feature.json and NOTES.md.

Hence, @daniel-meilak can we make the same changes to NOTES.md instead? Thanks!

@daniel-meilak
Copy link
Contributor Author

Hey @samruddhikhandale, here you go, hopefully this time the change persists 😄

@samruddhikhandale
Copy link
Member

Left a minor comment, thank you @daniel-meilak

@daniel-meilak
Copy link
Contributor Author

Nice spot, I've accepted the suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants