Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker-in-docker] - toggle ip6tables settings value as option #1068

Merged
merged 45 commits into from
Sep 16, 2024
Merged

[docker-in-docker] - toggle ip6tables settings value as option #1068

merged 45 commits into from
Sep 16, 2024

Conversation

gauravsaini04
Copy link
Contributor

Feature Name

  • Docker - in - Docker

Changelog

  • Changes to install.sh and devcontainer-feature.json files for features' issue #1023

Checklist

  • Checked that applied changes work as expected

@gauravsaini04 gauravsaini04 requested a review from a team as a code owner July 29, 2024 10:09
samruddhikhandale
samruddhikhandale requested changes Jul 29, 2024
View reviewed changes
src/docker-in-docker/devcontainer-feature.json Outdated Show resolved Hide resolved
src/docker-in-docker/devcontainer-feature.json Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
@shardulsrivastava shardulsrivastava mentioned this pull request Aug 3, 2024
Open
3 tasks
@gauravsaini04 gauravsaini04 mentioned this pull request Aug 19, 2024
Closed
@gauravsaini04 gauravsaini04 mentioned this pull request Aug 21, 2024
Closed
@gauravsaini04 gauravsaini04 marked this pull request as draft August 28, 2024 05:56
@gauravsaini04 gauravsaini04 marked this pull request as ready for review August 28, 2024 15:00
samruddhikhandale
samruddhikhandale requested changes Sep 3, 2024
View reviewed changes
src/docker-in-docker/devcontainer-feature.json Outdated Show resolved Hide resolved
src/docker-in-docker/devcontainer-feature.json Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
@samruddhikhandale samruddhikhandale linked an issue Sep 3, 2024 that may be closed by this pull request
docker-in-docker feature breaks with Codespaces+Kind and docker v27+ (docker's ipv6 breaking changes) #1023
Closed
samruddhikhandale
samruddhikhandale requested changes Sep 5, 2024
View reviewed changes
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
samruddhikhandale
samruddhikhandale reviewed Sep 6, 2024
View reviewed changes
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
samruddhikhandale
samruddhikhandale requested changes Sep 6, 2024
View reviewed changes
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
samruddhikhandale
samruddhikhandale requested changes Sep 9, 2024
View reviewed changes
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
samruddhikhandale
samruddhikhandale previously approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks wonderful ⚡

src/docker-in-docker/install.sh Outdated Show resolved Hide resolved
samruddhikhandale
samruddhikhandale approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@samruddhikhandale samruddhikhandale merged commit d926879 into devcontainers:main Sep 16, 2024
109 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker-in-docker feature breaks with Codespaces+Kind and docker v27+ (docker's ipv6 breaking changes)
2 participants
@gauravsaini04 @samruddhikhandale