-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a guide on prebuilds #277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome and pretty helpful!
Thank you, Brigit and Craig 👏 ✨
Discussed my comment on authors with Brigit offline :) |
This looks so great Brigit!! |
Incorporated feedback from yesterday's discussion (cross-link to this post from Chuck's guide on images vs dockerfile, added info on multi-stage builds). Would love another quick set of reviews, then I think we can merge this in and of course keep iterating in the future! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Maybe a separate sample repo just showing off prebuilds would makes it easier for users to get an overview of what is needed. Not a requirement though.
Fixes devcontainers/spec#261.
@craiglpeters I updated the info on the Kubernetes example a bit based on our chat last week - please feel free to propose other changes, or add in other tips/feedback from your experience working on the prebuild!
I also updated post.html to hopefully allow for 2 author posts correctly - cc @joshspicer in case you have any feedback on a different way to achieve this.
cc @olguzzar thanks again for the feedback - I'd love an additional review as I've incorporated your feedback and made a few more updates! I also created https://aka.ms/dev-container-prebuild that'll point to this guide for us to use in any docs or advocacy work.