Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a guide on prebuilds #277

Merged
merged 10 commits into from
Sep 5, 2023
Merged

Add a guide on prebuilds #277

merged 10 commits into from
Sep 5, 2023

Conversation

bamurtaugh
Copy link
Member

@bamurtaugh bamurtaugh commented Aug 28, 2023

Fixes devcontainers/spec#261.

@craiglpeters I updated the info on the Kubernetes example a bit based on our chat last week - please feel free to propose other changes, or add in other tips/feedback from your experience working on the prebuild!

I also updated post.html to hopefully allow for 2 author posts correctly - cc @joshspicer in case you have any feedback on a different way to achieve this.

cc @olguzzar thanks again for the feedback - I'd love an additional review as I've incorporated your feedback and made a few more updates! I also created https://aka.ms/dev-container-prebuild that'll point to this guide for us to use in any docs or advocacy work.

@bamurtaugh bamurtaugh requested a review from a team as a code owner August 28, 2023 20:26
@bamurtaugh bamurtaugh self-assigned this Aug 28, 2023
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome and pretty helpful!
Thank you, Brigit and Craig 👏 ✨

@joshspicer
Copy link
Member

I opened this PR up in a codespace (with bundle exec jeykll serve) and i'm not seeing the authors anymore 🤔
image

@joshspicer
Copy link
Member

Discussed my comment on authors with Brigit offline :)

joshspicer
joshspicer previously approved these changes Aug 28, 2023
@olguzzar
Copy link
Contributor

This looks so great Brigit!!

@bamurtaugh
Copy link
Member Author

Incorporated feedback from yesterday's discussion (cross-link to this post from Chuck's guide on images vs dockerfile, added info on multi-stage builds). Would love another quick set of reviews, then I think we can merge this in and of course keep iterating in the future!

@bamurtaugh bamurtaugh requested review from olguzzar, samruddhikhandale, joshspicer and Chuxel and removed request for olguzzar August 30, 2023 18:11
chrmarti
chrmarti previously approved these changes Aug 31, 2023
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Maybe a separate sample repo just showing off prebuilds would makes it easier for users to get an overview of what is needed. Not a requirement though.

_posts/2022-12-16-dockerfile.md Outdated Show resolved Hide resolved
@bamurtaugh
Copy link
Member Author

Thanks so much @chrmarti! That's great feedback, and I've opened a tracking issue (in case anyone from the community happens to have one they'd like to contribute too!): #281.

@bamurtaugh bamurtaugh enabled auto-merge (squash) September 1, 2023 21:26
@bamurtaugh bamurtaugh merged commit aa45280 into gh-pages Sep 5, 2023
@bamurtaugh bamurtaugh deleted the bamurtaugh/prebuild-guide branch September 5, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation of dev container image prebuild and update templates
6 participants