Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs for templates apply command #388

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Docs for templates apply command #388

merged 2 commits into from
Feb 2, 2023

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer commented Jan 30, 2023 •
edited
Loading

Documenting the discussion at devcontainers/spec#71 (comment)

@joshspicer joshspicer requested a review from a team as a code owner January 30, 2023 22:41
samruddhikhandale
samruddhikhandale previously approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

chrmarti
chrmarti requested changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Left a request.

docs/templates/apply.md Outdated Show resolved Hide resolved
chrmarti
chrmarti approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@joshspicer joshspicer merged commit 8e8c92c into main Feb 2, 2023
@joshspicer joshspicer deleted the joshspicer/templates-apply-cmd branch February 2, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrmarti chrmarti chrmarti approved these changes

@samruddhikhandale samruddhikhandale Awaiting requested review from samruddhikhandale

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshspicer @chrmarti @samruddhikhandale