-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache user env for performance improvement #374
Cache user env for performance improvement #374
Conversation
up
command for performance improvementThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left comments on details I previously missed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Two nits. Otherwise ready for merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
We've seen that user environment prob command often take multiple seconds to run, which slows down the commands
With this PR, the caller of the
up
command orrun-user-commands
command can optionally pass the cache directory name if they would like to use the cache.If a cache directory name is provided via
--container-session-data-folder
option, user envs will be cached in that directory, and the subsequent invocations will use the cache instead of probing user envs.