Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache user env for performance improvement #374

Merged
merged 6 commits into from
Jan 18, 2023
Merged

Cache user env for performance improvement #374

merged 6 commits into from
Jan 18, 2023

Conversation

eljog
Copy link
Member

@eljog eljog commented Jan 13, 2023

We've seen that user environment prob command often take multiple seconds to run, which slows down the commands

With this PR, the caller of the up command or run-user-commands command can optionally pass the cache directory name if they would like to use the cache.

If a cache directory name is provided via --container-session-data-folder option, user envs will be cached in that directory, and the subsequent invocations will use the cache instead of probing user envs.

@eljog eljog requested a review from a team as a code owner January 13, 2023 20:31
@eljog eljog changed the title Cache user env in up command for performance improvement Cache user env for performance improvement Jan 13, 2023
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left comments on details I previously missed.

src/spec-common/injectHeadless.ts Outdated Show resolved Hide resolved
src/spec-common/injectHeadless.ts Outdated Show resolved Hide resolved
src/spec-common/injectHeadless.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Two nits. Otherwise ready for merging.

src/spec-common/injectHeadless.ts Show resolved Hide resolved
src/spec-common/injectHeadless.ts Outdated Show resolved Hide resolved
chrmarti
chrmarti previously approved these changes Jan 18, 2023
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@samruddhikhandale samruddhikhandale merged commit 83c8030 into devcontainers:main Jan 18, 2023
@eljog eljog deleted the eljog/cache-userenvprob branch January 18, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants