support for touch events on mobile #23
Conversation
|
Hey, thank you for the PR! This looks good from the first glance. I'll try it out today. I'm curious though can you elaborate on what's the use case behind the |
|
Hey, thanks for looking into it! The |
|
Hey, I just tried the your touch supported version in the example project and I'm getting some weird behavior. Maybe I'm doing something wrong? If so, can you provide a CodeSandbox or similar example? Here's the video of me trying to use the splitter on my phone Thank you! |
| @@ -297,24 +303,33 @@ function Split({ | |||
| adjustSize(direction, offset); | |||
| }, [state.isDragging, state.draggingIdx, state.pairs, adjustSize]); | |||
|
|
|||
| function handleGutterMouseDown(gutterIdx: number, e: MouseEvent) { | |||
| e.preventDefault(); | |||
There was a problem hiding this comment.
I've got an error message while dragging with touch caused by this line:
Unable to preventDefault inside passive event listener invocation
I haven't found a use case for this. Everything works without this call, is there any specific reason to call preventDefault?
If yes, I'm happy to revert and migrate this line :)
|
Thanks for trying out. I should have tested the example project with my changes. The issue was the default scroll behaviour of the Now I've tested the example project with firefox and chrome on mobile and on desktop. |
|
Just tested it and all looks good. Thank you for the PR! I'll make a new release now. |
I've made some changes to support touch events on mobile.
If you like the changes I'd be happy to see them merged.
This would close #14