Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added changelog and common files #6

Merged
merged 1 commit into from
Nov 1, 2017
Merged

added changelog and common files #6

merged 1 commit into from
Nov 1, 2017

Conversation

atomic111
Copy link
Member

Signed-off-by: Patrick Münch [email protected]

Signed-off-by: Patrick Münch <[email protected]>
Copy link
Collaborator

@rarenerd rarenerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR.

@rarenerd
Copy link
Collaborator

rarenerd commented Nov 1, 2017

I have a refactor coming up that will get rid of the current process_env_var resource, so I'll accept the failing check there for now.

@rarenerd rarenerd merged commit ed91b29 into master Nov 1, 2017
@rarenerd rarenerd deleted the common branch May 30, 2018 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants