Add seperate tests for engine package
#14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves test coverage to 51%, with Value and Receiver tests remaining.
This completes work on seperating tests and brings test coverage to the ~90%. More corner cases will be covered as they arise.
deuill
added a commit
that referenced
this pull request
Jan 24, 2016
Add seperate tests for `engine` package
Closed
borancar
pushed a commit
to borancar/go-php
that referenced
this pull request
Dec 1, 2019
Turning off cg-monitor metrics push to elastic search Approved-by: Darren Izzard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the unified test-suite (located in the
php_test.gofile) and separates tests into package-specific files. Since tests now happen internally, it is possible to track test coverage (currently at around 90%), and will help improving the library against corner cases.