First version of PHP 7 support #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for building against PHP 7 when using the `php7` build tag (i.e. `go build -tags php7`). PHP 5 support remains the default and does not need passing any tags, currently, though this may change at some point. The code builds and basic tests run, but more advanced tests fail with "zend_mm_heap corrupted". More to come.
|
Currently, the code builds and basic tests run, but more advanced tests fail with "zend_mm_heap corrupted". More to come. |
This removes all "#ifdef PHP_MAJOR_VERSION" directives for version-specific header files per supported PHP version. These headers are included only when building against the specific PHP version, and are intended to abstract differences between implementations in a fairly clean way. This is still a mess of preprocessor directives, however.
This contains extensive API changes for the value package C bindings as well changes to the receiver package (addition of Destroy method and other small changes). These changes are mainly to address issues with PHP7 compatibility, but should also benefit PHP5 targets. Signed-off-by: Alex Palaistras <[email protected]>
Signed-off-by: Alex Palaistras <[email protected]>
|
Tests build on both PHP5 and PHP7 and I'm happy with the general code quality, so merging this. The whole pre-processor #define mess may be revisited at some point, though. |
borancar
pushed a commit
to borancar/go-php
that referenced
this pull request
Dec 1, 2019
lowering log level so we arent flooded with warnings for successful requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for building against PHP 7 when using the
php7build tag (i.e.go build -tags php7). PHP 5 support remains the default and does not need passing any tags, currently, though this may change at some point.